Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add jar files as lsp document selectors #1431

Merged
merged 3 commits into from
Dec 10, 2021

Conversation

ericdallo
Copy link
Contributor

Here are some things we consider before we merge:

  • We make sure the PR is directed at the dev branch (unless reasons).
  • We figured if anything about the fix warrants tests on Mac/Linux/Windows/Remote/Whatever, and will help you test there if it is hard for you to do so. (We appreciate a lot if you take on the work do this of course.)
  • We read the source changes. (Surprise! 😄)
  • We given feedback and guidance on source changes, if needed. Far from everything is captured in our code guidelines.
  • We use our domain knowledge to try catch if you have missed some facility already provided in the code base.
  • We read the updates to the documentation and help with feedback, trying to keep the documentation site serving well.
  • We often check out your code changes and test them.
  • We sometimes send the VSIX built from the PR out in the #calva channel on slack for others to test. (Actually, we will probably encourage you to do this.)
  • We sometimes have a chat within the team about particular changes.
  • NB: We also consider if your changes belong in the Calva product we want to maintain. Before you spend a lot of work on a PR, please consider chatting us up first, and filing issues.

We try to be speedy and attentive. Please don't hesitate to bump a PR, or contact us, if we seem to have dropped the ball (that has happened).

We use checklists in order to not forget about important lessons we and others have learnt along the way.

-->

What has Changed?

  • Add jar files to lsp document selector, adding all LSP features to those files as well

Fixes #1421

My Calva PR Checklist

I have:

  • Read How to Contribute.
  • Directed this pull request at the dev branch. (Or have specific reasons to target some other branch.)
  • Made sure I have changed the PR base branch, so that it is not published. (Sorry for the nagging.)
  • Updated the [Unreleased] entry in CHANGELOG.md, linking the issue(s) that the PR is addressing.
  • Figured if anything about the fix warrants tests on Mac/Linux/Windows/Remote/Whatever, and either tested it there if so, or mentioned it in the PR.
  • Added to or updated docs in this branch, if appropriate
  • Tested the VSIX built from the PR (so, after you've submitted the PR). You'll find the artifacts by clicking Show all checks in the CI section of the PR page, and then Details on the ci/circleci: build test. NB: You need to sign in/up at Circle CI to find the Artifacts tab.
    • Tested the particular change
    • Figured if the change might have some side effects and tested those as well.
    • Smoke tested the extension as such.
  • Referenced the issue I am fixing/addressing in a commit message for the pull request.
    • If I am fixing the issue, I have used GitHub's fixes/closes syntax
    • If I am fixing just part of the issue, I have just referenced it w/o any of the "fixes” keywords.
  • Created the issue I am fixing/addressing, if it was not present.

Ping @PEZ, @bpringe

@PEZ
Copy link
Collaborator

PEZ commented Dec 10, 2021

Awesome. Please update the changelog and this is good to go.

@ericdallo
Copy link
Contributor Author

Oh, I updated and just forgot to add and commit 😅

@PEZ PEZ merged commit 7d83647 into BetterThanTomorrow:dev Dec 10, 2021
@PEZ
Copy link
Collaborator

PEZ commented Dec 10, 2021

Haha, I noticed you had ticked that checkbox, but resisted to make a snarky comment about that. 😄

@ericdallo ericdallo deleted the fix-jar-lsp branch December 11, 2021 02:40
@bpringe
Copy link
Member

bpringe commented Dec 11, 2021

Thanks, @ericdallo!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants