Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix webpack builds for modern node versions #333

Merged
merged 1 commit into from
Mar 27, 2023
Merged

Fix webpack builds for modern node versions #333

merged 1 commit into from
Mar 27, 2023

Conversation

zerebos
Copy link
Member

@zerebos zerebos commented Mar 16, 2023

No description provided.

@Inve1951
Copy link
Member

why would the old config not work on newer node versions?

@zerebos
Copy link
Member Author

zerebos commented Mar 27, 2023

@Inve1951 old webpack4 did not work on modern node versions due to removal of the hashing functions for security reasons (https://github.com/BetterDiscord/Installer/actions/runs/4371207150/jobs/7646862697).

electron-builder builds a config for webpack4 (not 5) and has never been updated for webpack5, so we have to modify the config they generate to be compatible for webpack5

@zerebos zerebos merged commit b587fd4 into development Mar 27, 2023
@zerebos zerebos mentioned this pull request Mar 27, 2023
@Inve1951 Inve1951 deleted the webpack branch May 15, 2023 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants