Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possibility to use a different token than the one defined in the config #106

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Erenthil
Copy link

@Erenthil Erenthil commented Mar 3, 2018

No description provided.

@steve-perkins
Copy link
Contributor

Can you talk a bit about the use case(s) here? The fundamental design of the driver thus far has been that tokens are tied to VaultConfig objects, and passed to Vault objects one time at construction. If you need to use multiple tokens, then you simply have multiple Vault objects.

If someone is routinely using a variety of different tokens in the same area of code, then I could perhaps understand their preferences differing on that design. But I have to believe that this is an edge case rather than the typical norm, and breaking the existing pattern for it seems to be a bit muddled and confusing.

@fbourasse
Copy link

Sorry for the delay of response.
For me, the token should not be included in the object VaultConfig as multiple users can use the same address/timeout/ssl config but will use different token.

A solution would be to implement a SessionManager that can be extended as it's the case for the Spring Vault project.

Here is my use case :

  • A module is being added to a web app (Digital Experience Manager)
  • This module is instantiating a Spring bean to one Vault/VaultConfig
  • This bean will be used by each user to fetch with his personal token his own data

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants