Skip to content

Commit

Permalink
Fix for version comparisons from strings to semver (helm#4607)
Browse files Browse the repository at this point in the history
* Fix for version comparisons from strings to semver

See helm#3002 for more detail

* Adding appVersion to pass validation

* Include pre-releases in the semver ranges

This is important when testing against alpha and beta builds of
Kubernetes along with environments that use pre-releases to denote
things other than pre-releases (e.g., gke denotes the environment
with a pre-releases)
  • Loading branch information
mattfarina authored and Jean-Noël Vouilloz committed May 15, 2018
1 parent 99a115c commit ce86947
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 3 deletions.
5 changes: 3 additions & 2 deletions stable/spotify-docker-gc/Chart.yaml
Original file line number Diff line number Diff line change
@@ -1,9 +1,10 @@
name: spotify-docker-gc
home: https://github.com/spotify/docker-gc
version: 0.1.2
version: 0.1.3
appVersion: latest
description: A simple Docker container and image garbage collection script.
sources:
- https://github.com/spotify/docker-gc
maintainers:
- name: Vaughn Dice
- name: vdice
email: [email protected]
2 changes: 1 addition & 1 deletion stable/spotify-docker-gc/templates/daemonset.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ kind: DaemonSet
metadata:
name: {{ template "name" . }}
spec:
{{- if ge .Capabilities.KubeVersion.Minor "6" }}
{{- if semverCompare "^1.6-0" .Capabilities.KubeVersion.GitVersion }}
updateStrategy:
type: RollingUpdate
{{- end }}
Expand Down

0 comments on commit ce86947

Please sign in to comment.