Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Suggestion] Remove Step Assist from Flight's default requirements #46

Open
Tomska95 opened this issue Dec 7, 2024 · 3 comments
Open
Assignees
Labels
bug Something isn't working

Comments

@Tomska95
Copy link

Tomska95 commented Dec 7, 2024

Describe the bug
One of the three requirements for flight is actually step assist instead of jump boost.

To Reproduce
Steps to reproduce the behavior:

  1. Have Teleport, No fall damage and Jump boost injected.
  2. Try to inject Flight
  3. Flight fades away as it is looking for Step assist instead of Jump boost

Expected behavior
The requirement should be jump boost as that is what is listed in the guide book.

Additional context
Step assist can be extremely annoying especially when your movement speed is boosted and it doesn't have any benefit for a player that can fly. Jump Boost also makes more sense as a requirement for flight.

@Tomska95 Tomska95 added the bug Something isn't working label Dec 7, 2024
@aaronhowser1
Copy link
Member

I think this is backwards actually. Jump Boost was the original requirement, but I thought that it would be annoying to force people to have jump boost, meanwhile Step Assist is basically always wanted (I thought) and is still relevant to moving upwards. The guide is outdated, rather than the requirements being wrong

@aaronhowser1
Copy link
Member

You can replace the file /data/geneticsresequenced/geneticsresequenced/gene_requirements/flight.json with

{
  "gene": "geneticsresequenced:flight",
  "requirements": [
    "geneticsresequenced:teleport",
    "geneticsresequenced:jump_boost",
    "geneticsresequenced:no_fall_damage"
  ]
}

with KubeJS for now, if you want an instant fix. I'll get a third opinion on if Jump Boost or Step Assist is a better option

@aaronhowser1 aaronhowser1 changed the title [Bug] Flight has incorrect prerequisites [Bug] Guide has the wrong default prerequisite Genes for Flight Dec 7, 2024
@Tomska95
Copy link
Author

Tomska95 commented Dec 7, 2024

Thanks for the reply. An alternate requirement that doesn't divide the playerbase by forcibly altering movement would certainly be nice. The extra genes can always be added if someone wants to use them. Ultimately the decision up to you as the mod dev.

@aaronhowser1 aaronhowser1 changed the title [Bug] Guide has the wrong default prerequisite Genes for Flight [Suggestion] Remove Step Assist from Flight's default requirements Dec 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants