Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge protobuf_and_authentication_for_community_post_poll_vote_details_retrieval branch #265

Closed
Benjamin-Loison opened this issue Apr 11, 2024 · 10 comments
Assignees
Labels
enhancement New feature or request medium priority A high-priority issue noticeable by the user but he can still work around it. official instance quick A task that should take less than two hours to complete.

Comments

@Benjamin-Loison
Copy link
Owner

Benjamin-Loison commented Apr 11, 2024

protobuf_and_authentication_for_community_post_poll_vote_details_retrieval.

As someone asked on Discord if these changes were deployed on the official instance.

Let us investigate the Windows case:

Chocolatey: protoc
protocolbuffers/protobuf/releases/latest

Chocolatey: composer
composer/windows-setup/releases/latest

git clone https://github.com/Benjamin-Loison/YouTube-operational-API --branch protobuf_and_authentication_for_community_post_poll_vote_details_retrieval

https://www.youtube.com/channel/UCQxJsAlqmBPAbR_0syDi9mg/community?lb=UgwSoAm2bGLaJM44UTZ4AaABCQ

@Benjamin-Loison Benjamin-Loison added enhancement New feature or request official instance low priority Nice to have feature. quick A task that should take less than two hours to complete. labels Apr 11, 2024
@Benjamin-Loison
Copy link
Owner Author

Facing similar issue as #268:

grep -r '\${'
community.php:    return array_map(fn($k, $v) => "${k}${separator}${v}", array_keys($anArray), array_values($anArray));
community.php:    $SAPISIDHASH = "${currentTime}_" . sha1("$currentTime $SAPISID $ORIGIN");

@Benjamin-Loison
Copy link
Owner Author

Benjamin-Loison commented Jul 5, 2024

Should leverage includeOnceProto{,s} before merging:

    function includeOnceProto($proto) {
        $COMMON_PATH = 'proto/php';
        include_once "$COMMON_PATH/$proto.php";
        include_once "$COMMON_PATH/GPBMetadata/$proto.php";
    }
    
    function includeOnceProtos($protos) {
        foreach($protos as $proto) {
            includeOnceProto($proto);
        }   
    }

@Benjamin-Loison
Copy link
Owner Author

Related to issues/295#issuecomment-2269988654.

@Benjamin-Loison
Copy link
Owner Author

@Benjamin-Loison Benjamin-Loison self-assigned this Sep 15, 2024
@Benjamin-Loison Benjamin-Loison added medium priority A high-priority issue noticeable by the user but he can still work around it. and removed low priority Nice to have feature. labels Sep 15, 2024
@Benjamin-Loison
Copy link
Owner Author

git branch -l
  get_video_endscreen
* main
  meta
  protobuf_and_authentication_for_community_post_poll_vote_details_retrieval
  provide_google_abuse_exemption_cookie

@Benjamin-Loison
Copy link
Owner Author

git branch -r
  origin/HEAD -> origin/main
  origin/get_video_endscreen
  origin/main
  origin/meta
  origin/protobuf_and_authentication_for_community_post_poll_vote_details_retrieval
  origin/provide_google_abuse_exemption_cookie

@Benjamin-Loison
Copy link
Owner Author

The Stack Overflow question 38206196 does not clearly help, I would like to append commits of the development branch.

@Benjamin-Loison
Copy link
Owner Author

Let us cherry-pick one commit at a time.

git cherry-pick 91ca212068c80e3ee82240263793f25ba7764ddb
Auto-merging README.md
CONFLICT (content): Merge conflict in README.md
error: could not apply 91ca212... Correct Windows `protoc` command
hint: After resolving the conflicts, mark them with
hint: "git add/rm <pathspec>", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".

Maybe it is because I forced pushed at the time or was not synchronized locally and remotely and pushed a branch as is.

@Benjamin-Loison
Copy link
Owner Author

Benjamin-Loison commented Sep 15, 2024

I confirm today pushed commits to correctly be able to load voteRatios locally.

@Benjamin-Loison
Copy link
Owner Author

Benjamin-Loison commented Sep 15, 2024

On the official instance voteRatio values are null, do not investigate until someone complains, as the only user leveraging this feature in theory uses his own instance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request medium priority A high-priority issue noticeable by the user but he can still work around it. official instance quick A task that should take less than two hours to complete.
Projects
None yet
Development

No branches or pull requests

1 participant