Thread-Safety for NoiseGenerator and Tile/Gridmaps #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bringing my fork into the future.
…calls on Tile/Gridmap Renderers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a few adjustments in response to #126.
This PR does two things:
generate_chunkmethod thread-safe (using deferred signal emissions).set_cellanderase_cellcalls inside of Tile/GridmapGaeaRender's_draw_areamethod.As for the lag issue, the proposed solution is to replace these deferred calls with
call_thread_safe. This fixes the issue by ensuring that when threaded,_draw_areawon't try to queue up significant numbers of deferred but expensive calls. Instead it will wait for the completion of one, then go to the next, and so on (all without blocking the main thread).