Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added in Discord Activity updater #34

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Conversation

gand0rf
Copy link
Contributor

@gand0rf gand0rf commented Nov 26, 2024

Added in the function to turn on and off a discord updater. Doesn't display an image right now, but will look at adding that in the future. Uses discord-rich-preasence to talk to discord api. Configurable from config file.

Copy link
Owner

@Benexl Benexl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks great just some minor fixes are required

fastanime/cli/interfaces/anilist_interfaces.py Outdated Show resolved Hide resolved
@@ -0,0 +1,16 @@
from discordrp import Presence
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why discordrp over the popular pypresence

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't pop up in my research. Will check it out and see about it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks interesting, but I see a way to actually set the activity type like I can with discordrp. Reaching out to pypresence discord to see if someone might be able to help.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pypresence is not being actively maintained anymore.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The one you are using is even less maintained, so just use pypresence, the api is the same.

uv.lock Outdated Show resolved Hide resolved
@crispy-caesus
Copy link

links to #30

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants