Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support spreadsheets.values.append method #168

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

bpholt
Copy link
Contributor

@bpholt bpholt commented Jan 11, 2021

No description provided.

@codecov-io
Copy link

Codecov Report

Merging #168 (0bcdddc) into master (45e784d) will decrease coverage by 56.30%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #168       +/-   ##
===========================================
- Coverage   95.77%   39.47%   -56.31%     
===========================================
  Files           5        5               
  Lines          71       76        +5     
===========================================
- Hits           68       30       -38     
- Misses          3       46       +43     
Impacted Files Coverage Δ
...sheets4s/interpreters/RestSpreadsheetsValues.scala 0.00% <0.00%> (-100.00%) ⬇️
src/main/scala/gsheets4s/model.scala 90.90% <0.00%> (-5.97%) ⬇️
src/main/scala/gsheets4s/GSheets4s.scala 0.00% <0.00%> (-100.00%) ⬇️
...in/scala/gsheets4s/http/GSheets4sDefaultUrls.scala 0.00% <0.00%> (-100.00%) ⬇️
src/main/scala/gsheets4s/http/HttpClient.scala 0.00% <0.00%> (-93.11%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 45e784d...0bcdddc. Read the comment docs.

Copy link
Owner

@BenFradet BenFradet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks a lot 👍
We might want to add an integration test leveraging appendAndGet though wdyt?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants