Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sync should add duplicate title field to lower-case #13

Open
OriHoch opened this issue Jun 19, 2017 · 3 comments
Open

sync should add duplicate title field to lower-case #13

OriHoch opened this issue Jun 19, 2017 · 3 comments
Assignees
@TheGrandVizier
Labels
clearmash enhancement

Comments

@OriHoch
Copy link
Contributor

OriHoch commented Jun 19, 2017

reproduction

  • sync some documents from any source which have title_en and title_he fields
  • look at resulting data in Elasticsearch

expected

  • should have additional fields:
    • title_en_lc
    • title_he_lc
    • also for any other language if exists
  • these fields help to do case-insensitive search while also supporting suggest

actual

  • no _lc fields in Elasticsearch
@Libisch Libisch self-assigned this Jun 25, 2017
@Libisch Libisch mentioned this issue Jun 27, 2017
Merged
@Libisch
Copy link
Contributor

Libisch commented Jun 27, 2017 •
edited
Loading

PR #26

Libisch added a commit that referenced this issue Jul 3, 2017
@Libisch
Merge pull request #26 from Libisch/13-title_lc
edf29a1 
#13 Add lower-case to titles on sync
@Libisch
Copy link
Contributor

Libisch commented Jul 3, 2017

@TheGrandVizier This can't be tested yet, I assigned myself in order to remind you ones changes are visible for QA.

@OriHoch
Copy link
Contributor Author

OriHoch commented Jul 3, 2017

merged and deployed to dev in 0.1.1

@Libisch Libisch assigned TheGrandVizier and unassigned Libisch Jul 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TheGrandVizier TheGrandVizier

Labels
clearmash enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@OriHoch @TheGrandVizier @Libisch