Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translate filter button for hebrew version #395

Closed
TheGrandVizier opened this issue May 21, 2017 · 4 comments
Closed

Translate filter button for hebrew version #395

TheGrandVizier opened this issue May 21, 2017 · 4 comments
Assignees
@Netush
Milestone
Delivered 12JUN2017

Comments

@TheGrandVizier
Copy link
Contributor

Since we have all the other buttons translated it stands to reason this one is not different.

Reproduce:

  1. use general search to find a person
  2. Use general search family tree filters
  3. Switch to Hebrew interface

Actual result:
Filter button is the only element on screen still in English.

Expected result:
All elements on the screen are now in hebrew.
@nuritgazit
Copy link
Contributor

לדעתי "סינון"

@Netush
Copy link

Netush commented May 21, 2017

זה סינון - אפשר לעיין גם בסקיצות
https://projects.invisionapp.com/d/main#/console/904587/218273109/preview

@Inna-r Inna-r added this to the High Priority Front milestone May 22, 2017
Inna-r added a commit to Inna-r/dbs-front that referenced this issue May 23, 2017
@Inna-r
Translate filter button for hebrew version
3480121 
issue Beit-Hatfutsot#395
@Inna-r Inna-r mentioned this issue May 23, 2017
Merged
@OriHoch
Copy link
Contributor

OriHoch commented Jun 5, 2017

@TheGrandVizier why? it was fixed and merged
please write why it was reopened and what changes are needed

@TheGrandVizier
Copy link
Contributor Author

I accidentally closed it, and thus reopened it. It was not meant to be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Netush Netush

Labels
None yet
Projects
None yet
Milestone
Delivered 12JUN2017
Development

No branches or pull requests
5 participants
@OriHoch @Inna-r @TheGrandVizier @nuritgazit @Netush