Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

family trees search: viewing person in tree from search results should work #382

Closed
OriHoch opened this issue May 16, 2017 · 2 comments
Closed

family trees search: viewing person in tree from search results should work #382

OriHoch opened this issue May 16, 2017 · 2 comments
Milestone
Delivered 12JUN2017

Comments

@OriHoch
Copy link
Contributor

OriHoch commented May 16, 2017

reproduction

  • general search for "בלה כהן"
  • click on People tab
  • in the results - click on "בלה כהן"

image

expected

  • see "בלה כהן" in family tree

actrual

  • nothing is shown
  • network tab shows 404 error from API

image
@OriHoch
Copy link
Contributor Author

OriHoch commented May 16, 2017

opening the same person from the "old" family trees tab works -
http://test.dbs.bh.org.il/person/10822/0/I104

Inna-r added a commit to Inna-r/dbs-front that referenced this issue May 21, 2017
@Inna-r
use the right person id property to build person's link
c48c50c 
issue Beit-Hatfutsot#382
Inna-r added a commit to Inna-r/dbs-front that referenced this issue May 21, 2017
@Inna-r
use available person id property to build person's link
2f1df26 
issue Beit-Hatfutsot#382
@TheGrandVizier
Copy link
Contributor

TheGrandVizier commented May 21, 2017 •
edited
Loading

This was a duplicate:
#398
I closed it and keeping this one.

Inna-r added a commit that referenced this issue May 23, 2017
@Inna-r
Merge pull request #399 from Inna-r/viewing_person_in_tree_from_searc…
069bd83 
…h_results_should_work_#382

Viewing person in tree from search results should work #382
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Delivered 12JUN2017
Development

No branches or pull requests
2 participants
@OriHoch @TheGrandVizier