Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update text in About Family Names page #324

Closed
nuritgazit opened this issue Mar 15, 2017 · 6 comments
Closed

Update text in About Family Names page #324

nuritgazit opened this issue Mar 15, 2017 · 6 comments

Comments

@nuritgazit
Copy link
Contributor

nuritgazit commented Mar 15, 2017

This page:
Hebrew
English

Should have the same text as this page:
Hebrew
English

@OriHoch
Copy link
Contributor

OriHoch commented Mar 21, 2017

reproduction steps

expected
  • the main page text (not including side-bar / header / footer) should show the text from the www.bh.org.il site:
  • only the main page text is needed (not including side-bar / header /footer)
  • format and design are not important, just copy the plain text and headings
actual
  • only a single paragraph is displayed

@OriHoch
Copy link
Contributor

OriHoch commented Mar 21, 2017

@nuritgazit - please approve my previous comment to ensure I understood correctly what's needed..

@nuritgazit
Copy link
Contributor Author

@OriHoch approved, but I think @Libisch is on it? we talked about it briefly yesterday, but maybe you are too quick for her

@OriHoch
Copy link
Contributor

OriHoch commented Mar 21, 2017

I'm not saying I will do it, I'm just making sure we have backlog of issues ready for work
@Libisch - please assign yourself to an issue if you are working on it

@Libisch Libisch self-assigned this Mar 22, 2017
Libisch added a commit to Libisch/dbs-front that referenced this issue Mar 22, 2017
Libisch added a commit to Libisch/dbs-front that referenced this issue Mar 22, 2017
@Libisch
Copy link
Contributor

Libisch commented Mar 27, 2017

@OriHoch @nuritgazit @TheGrandVizier
Text was added but we must not redirect until SEO is applied to these pages. The SEO guys are working on it.

@OriHoch
Copy link
Contributor

OriHoch commented Mar 27, 2017

@Libisch
I don't see any reason not to move forward with this issue - it is not dependent on the SEO issue

(moving forward = merging the fix / testing / deploying )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants