Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

free text linkify should work on new (clearmash) infrastructure #212

Open
OriHoch opened this issue Jul 17, 2017 · 8 comments
Open

free text linkify should work on new (clearmash) infrastructure #212

OriHoch opened this issue Jul 17, 2017 · 8 comments
Assignees

Comments

@OriHoch
Copy link
Contributor

OriHoch commented Jul 17, 2017

reproduction

expected

actual

  • error

notes

  • probably due to the migration to the new search infra
@OriHoch
Copy link
Contributor Author

OriHoch commented Jul 18, 2017

fixed and deployed to dev

@OriHoch OriHoch assigned TheGrandVizier and nirgoldberg and unassigned OriHoch Jul 18, 2017
@TheGrandVizier
Copy link

It works, but takes a very very long time.
Do we expect the links to show up on Nirs pages with a delay after loading the page?

@nirgoldberg
@nuritgazit

@nuritgazit
Copy link

no, we expect them to appear when the pages load

@nirgoldberg
Copy link

@OriHoch, for some reason this feature stopped working.
Can you take a look at that?

@nirgoldberg nirgoldberg reopened this Oct 2, 2017
@OriHoch
Copy link
Contributor Author

OriHoch commented Oct 3, 2017

we recently reverted back to old version of the code - before Clearmash changes

IIRC this feature was implemented on the new architecture - which doesn't exist anymore..

@nirgoldberg do you know when this stopped working? we reverted back to old architecture around Sep 12

If my assumption is correct that it never worked on the old architecture - then I guess it will take a few hours work to adjust or re-develop this feature for the old architecture (if there aren't any unexpected problems)

@nuritgazit please approve this work

@OriHoch
Copy link
Contributor Author

OriHoch commented Oct 3, 2017

this is the url on production environment (We don't have dev anymore):
https://api.dbs.bh.org.il/v1/linkify?html=hello%20from%20germany

looks like indeed it's just not there (returns 404)

@OriHoch OriHoch self-assigned this Oct 3, 2017
@nuritgazit
Copy link

@OriHoch approved

@OriHoch
Copy link
Contributor Author

OriHoch commented Nov 15, 2017

fixed and deployed
(it's still slow and buggy as it was...)

@OriHoch OriHoch removed their assignment Nov 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants