Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backend suggest api endpoint should provide basic suggestions #118

Closed
TheGrandVizier opened this issue Mar 7, 2017 · 6 comments
Closed
Assignees

Comments

@TheGrandVizier
Copy link

TheGrandVizier commented Mar 7, 2017

As the user is typing a search term, provide a list of suggestions that begin with what the user is typing.

Must suggest items of all types that are ours:

  • Family names
  • Places
  • Luminaries
  • Images
  • Persons
  • Compendium
  • Stories
  • Video
  • Music

It should provide up to 5 suggestions as "Starts with".
If there is an exact match, suggest the exact match.

Future-proofing (bonus points): Add support for 5 items as "Sounds like".

@OriHoch
Copy link
Contributor

OriHoch commented Mar 8, 2017

the backend should provide an api call which gets a (possibly partial) search term and returning a list of suggestions

the main thing to determine for this issue is where it gets the suggestions from

I think for this iteration we can take is based on whatever data we have in our Elasticsearch - which currently means all the BHP data. In the future when we move to Clearmash we will still need to have some of the data stored in Elasticsearch to use for autosuggest (for example, we will keep the list of places and list of family names in our local instance with some migration)

@nuritgazit
Copy link

@OriHoch Just make sure not to pull information from "databases" other than the ones mentioned by @TheGrandVizier above, cause there are things like "donors" etc. that we mustn't use.

@OriHoch OriHoch self-assigned this Mar 8, 2017
OriHoch added a commit to OriHoch/dbs-back that referenced this issue Mar 13, 2017
OriHoch added a commit to OriHoch/dbs-back that referenced this issue Mar 13, 2017
OriHoch added a commit to OriHoch/dbs-back that referenced this issue Mar 13, 2017
OriHoch added a commit to OriHoch/dbs-back that referenced this issue Mar 14, 2017
OriHoch added a commit to OriHoch/dbs-back that referenced this issue Mar 20, 2017
@OriHoch OriHoch changed the title General search should provide suggestions similar to the wizard. backend suggest api endpoint should provide basic suggestions Mar 20, 2017
@OriHoch
Copy link
Contributor

OriHoch commented Mar 27, 2017

merged + deployed to test

see release notes for details

@OriHoch
Copy link
Contributor

OriHoch commented Mar 27, 2017

@TheGrandVizier - sorry, not ready for testing yet, need to run indexing for elasticsearch

@OriHoch
Copy link
Contributor

OriHoch commented Mar 27, 2017

now it's deployed

@OriHoch
Copy link
Contributor

OriHoch commented Mar 28, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants