Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

subtree sequence #8

Closed
liuxin00738 opened this issue Nov 21, 2018 · 6 comments
Closed

subtree sequence #8

liuxin00738 opened this issue Nov 21, 2018 · 6 comments

Comments

@liuxin00738
Copy link

Hi Davide,

I find a new issue of the groot. If I have more than one sub-tree for a sequence, the groot seems to put the subtree in the wrong order.

@facontidavide
Copy link
Contributor

Thanks for reporting. I will add the unit test and fix the issue tomorrow

@facontidavide
Copy link
Contributor

facontidavide commented Nov 22, 2018

I can't see what is wrong based on your description. Can you share an XML file to reproduce this?

The attached file seems to work just fine.

show_all_sub.zip

@liuxin00738
Copy link
Author

tree.tar.gz

Hi Davide,

Please see the attached xml and groot picture. Please notice that both the subtree and the sequence node are in wrong order. It seems to be related to the name or string I give them. And if I change the name sometimes the order is correct. But the one I send is wrong all the time for my machine.

@facontidavide
Copy link
Contributor

Ok, I see. the error can be reproduced easily with the simplified tree

    <BehaviorTree ID="PickingItem">
            <Action ID = "AdjustTCPOrientation"/>
    </BehaviorTree>
    <BehaviorTree ID="MoveToPredefinedPoint">
            <Action ID = "LinearMove"/>
    </BehaviorTree>

    <BehaviorTree ID="MainTree">
        <Sequence name="move from bin A to bin B">
            <SubTree ID = "MoveToPredefinedPoint"/>
            <SubTree ID = "PickingItem"/>
        </Sequence>
    </BehaviorTree>
</root>

I will fix it today.
By the way, you also gave me an idea for an improvement in the visualization ;)

facontidavide pushed a commit that referenced this issue Nov 23, 2018
facontidavide pushed a commit that referenced this issue Nov 23, 2018
- Added EditorFlowScene::createNodeAtPos to simplify code
- fixed the placement of nodes in GraphicContainer::recursiveLoadStep
- visualize instanceName is different than registrationName
@facontidavide
Copy link
Contributor

Ok, I found the bug (it was a nasty one) and I have also made some additional changes.

Test the dev branch if you can.

I also changed the way nodes with names are displayed:

image

@facontidavide
Copy link
Contributor

By the way, I also noticed thanks to your screenshot a small error in the auto-arrange function. I correct it.
See the before and after pictures
screenshot from 2018-11-22 13-42-04
selection_100

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants