Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw an exception only if the bootstrap file is not the default one #135

Merged

Conversation

sroze
Copy link
Contributor

@sroze sroze commented Nov 28, 2017

This fixes the issue /issues/132

@@ -125,7 +126,7 @@ public function process(ContainerBuilder $container)
require_once($bootstrap);
} elseif (file_exists($bootstrapPath)) {
require_once($bootstrapPath);
} else {
} elseif ($bootstrapPath != self::DEFAULT_KERNEL_BOOTSTRAP) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please use strict comparison

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, can do. What's the difference to you?

@sroze sroze force-pushed the throw-an-exception-only-if-bootstrap-is-not-the-default-one branch from 747dae2 to 1cda571 Compare November 30, 2017 11:19
@sroze sroze merged commit 022ece0 into master Dec 13, 2017
@sroze sroze deleted the throw-an-exception-only-if-bootstrap-is-not-the-default-one branch December 13, 2017 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants