Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Framing Tool #7253

Open
wants to merge 19 commits into
base: dev
Choose a base branch
from
Open

Add Framing Tool #7253

wants to merge 19 commits into from

Commits on Nov 18, 2024

  1. Configuration menu
    Copy the full SHA
    96ad705 View commit details
    Browse the repository at this point in the history
  2. Add framing tool GUI

    * Added under the Resize tool like PR sharpening
    * Adds FramingParams and FramingParamsEdited structs
    * No parameter read/write implemented
    * No support for batch mode
    * No adjuster listeners implemented
    * Signals and callback functions are defined but do nothing
    digitalcarp committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    03a73eb View commit details
    Browse the repository at this point in the history
  3. Add RAII listener blocking utility

    * Added for ToolPanel listener and Adjuster
    * Follows style of ConnectionBlocker for sigc::connection
    digitalcarp committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    b472fbf View commit details
    Browse the repository at this point in the history
  4. Add framing tool ProcParams

    * Adds FramingParams parameter struct to ProcParams
    * Implement saving and writing to struct from framing tool GUI
    digitalcarp committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    8e68ecc View commit details
    Browse the repository at this point in the history
  5. Implement load/save for FramingParams

    * Implement writing FramingParams to keyfile
    * Implement reading FramingParams from keyfile
    digitalcarp committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    d114853 View commit details
    Browse the repository at this point in the history
  6. Implement FramingParamsEdited operations

    * Implements edited param manipulation operations for framing tool
    digitalcarp committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    114a468 View commit details
    Browse the repository at this point in the history
  7. Implement partial profile for framing tool

    * Update partial profile load/save GUI to include framing tool
    * Allows for loading/saving framing tool parameters from the clipboard
    digitalcarp committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    757a0a0 View commit details
    Browse the repository at this point in the history
  8. Implement ProcEvents for framing tool

    * Add new events to ProcEvents
    * Add new events to refresh map under RESIZE category
    * Add new strings for displaying events in history panel
    * Hook up GUI events with emitting ProcEvents
    digitalcarp committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    29945f4 View commit details
    Browse the repository at this point in the history
  9. Tweak framing tool GUI

    * Set sensitivity of aspect ratio and orientation combo boxes
    * Sensitivity determined by absolute/relative sizing method
    * Show allow upscaling box for BBOX framing method
    digitalcarp committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    b88ad56 View commit details
    Browse the repository at this point in the history
  10. Calculate required image and frame sizes

    * Refactor simpleprocess.cc to be more clear on resize dimensions
    * Implement image and frame sizing calculations
    * Resizes the image based on adjusted framing calculations
    * Missing functionality to draw border around image after resizing
    digitalcarp committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    a96dc4c View commit details
    Browse the repository at this point in the history
  11. Implement drawing border for framing tool

    * Draws border after all resize operations are complete
    * Update the RGB sliders for 16-bit channels
    digitalcarp committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    7ccab91 View commit details
    Browse the repository at this point in the history
  12. Fix framing tool batch mode behavior

    * Add adjuster add/set options to preferences
    * Update width/height limits
    * Trim adjuster values
    * Batch mode fixes
      * Display all settings with sensitivity
      * Add "(Unchanged)" option to combo boxes
      * Fix checked button toggle modes
    digitalcarp committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    55480f4 View commit details
    Browse the repository at this point in the history
  13. Fix computation errors in framing tool

    * Compute image aspect ratio if required instead of leaving at 0
    * Fix divide by zero error in computing framed size
    * Compute resize scale based on original crop
    * Reword "Current" aspect ratio to "As Image"
    digitalcarp committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    4358c2d View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    2458ba4 View commit details
    Browse the repository at this point in the history
  15. Improve framing tool usability

    * Rename "Resize" to "Resize & Framing" from discoverability
    * Add ColorPreview class for displaying a solid color
    * Add border color preview
    digitalcarp committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    57ef07f View commit details
    Browse the repository at this point in the history
  16. Configuration menu
    Copy the full SHA
    bbb3efd View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    45bde1c View commit details
    Browse the repository at this point in the history

Commits on Nov 25, 2024

  1. Fix bugs in framing tool sizing

    * Fix incorrect uniform relative border size calculation
    * Fix minimum size requirements not being respected
    * Drive-by code formatting changes
    digitalcarp committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    c9c12f3 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    0c29443 View commit details
    Browse the repository at this point in the history