WIP: Bundled profile for reference image #6646
Conversation
Also adds a linear sRGB profile to the bundled output profiles - a linear output profile is the most important component here. Should eliminate the need for the "reference image" custom function and associated code, and solve issue Beep6581#5575
Stripped irrelevant keys. Profile to be applied using "Fill" mode.
Yes, less duplication means less bloat, less code maintenance, less documentation maintenance.
sRGB seems to mimic the workings of the now-obsolete button, so I'd stick to that. I proposed a change to the PP3 to strip all irrelevant keys. This makes it clear what the profile is mean to do when you look at it in a text editor, and ensures the profile won't break in RT when a tool is added or modified. I'm not sure whether you want to include the |
|
HLRecovery was the default for what I started with - in theory it probably should be disabled, but in practice any image that has been exposed in such a way as for it to matter is one that is fundamentally not suitable to being used as a reference image. I'm fine with nuking it since it's basically a NOP for a proper target shot anyway. Also fine with stripping the unused/irrelevant keys - I'll review/test that later this week. I'm entering "holiday vacation packing" phase soon. :) As to sRGB - in general, as long as output = working it should be functionally identical, since "no profile" on input and output=working leads to an effective NOP with respect to gamut transforms. sRGB linear as an output profile is probably more useful to people for bundling as there are other use cases for it until a better long-term solution for #6644 can be determined and implemented ProPhoto as working matches the current default working profile of RT (e.g. it isn't a change from the defaults while sRGB is) Probably usefulness of the bundled profile wins, unless you've got thoughts as far as a more "common" use case as far as gamut for output profile. |
|
@Beep6581 thinking about this more - I'm not sure what Hugin will do if the input gamut is other than sRGB. If the attached ICC profile indicates linear encoding it does respect that, but who knows what for the gamut. I do know that if the input is flagged as linear with sRGB gamut, Hugin's output will be linear data that has not had any gamut transformations applied (since we all know it isn't actually sRGB, we just want to ensure that all gamut transforms are no-ops). My use case for the original issue was making it less painful to use Hugin to defish the reference images from a fixed-lens fisheye camera, and it also makes pulling fiduciary coordinates with GIMP a lot easier. Also, do you know if there's an "ignore user" function in github? There's a block feature but that's probably overkill for the moment. |
@Entropy512 I agree that not performing HLrec is probably for the best considering this processing profile's use case. Thumbs up for merging if you either remove the
If you block the user, from your perspective it will be like an ignore. |
|
@Entropy512 please provide info on how to use this profile before merging to dev. Either directly to RawPedia, or here and then I will add it to RawPedia. |
|
Apologies for not finishing up/cleaning things on this including some of the other outstanding comments. I'll try to revisit this over the weekend. I'm finally going to start to have more free time again soon to resume the 2137931270721390 different things I've been procrastinating on lately. I don't think I have rawpedia access - I have been planning on requesting access, but decided to put it off based on the discussion over on pixls regarding a likely migration to a static site with hugo + pull requests. (that is a separate issue/discussion but I'm willing to help with that if needed, I'm planning on pushing for a similar migration at my dayjob.) |
|
I've noticed you're back and active again @Beep6581 - any news on the replacement for rawpedia discussed in https://discuss.pixls.us/t/an-update-on-rawpedia/34168 ? It would be preferable to add the documentation in question to whatever replaces Rawpedia, instead of to the old system. |
|
@Entropy512 nothing in the form of news yet, but certainly much motivation (inversely proportional to available time). Would be good to have this in 5.10, and it's the kind of thing that does not need to be in beta1. You could provide just a stub paragraph/list of steps here in plaintext describing how to use it, and I'll add it to the docs. |
Solves #5575
TBD: Remove the reference image code now that it is superseded?
Also: Currently everything is set to sRGB - we can basically choose any colorspace as long as output = working and the input camera profile is disabled. Any preferences?