Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for versioningit and stuff #65

Merged
merged 14 commits into from
Dec 23, 2023
Merged

Update for versioningit and stuff #65

merged 14 commits into from
Dec 23, 2023

Conversation

IAlibay
Copy link
Collaborator

@IAlibay IAlibay commented Nov 9, 2023

No description provided.

@IAlibay
Copy link
Collaborator Author

IAlibay commented Nov 9, 2023

CI hasn't been running for a long while, let's see what happens...

@orbeckst
Copy link
Member

Thanks for starting the work.

For reference I am copying the current failures from setuptools:

[WARNING ] versioningit: Version extracted from tag 'release-2.0.0' is not PEP 440-compliant
      [ERROR   ] versioningit: InvalidVersionError: Cannot parse version 'release-2.0.0'
      error: Multiple top-level packages discovered in a flat-layout: ['devtools', 'propkatraj'].
      
      To avoid accidental inclusion of unwanted files or directories,
      setuptools will not proceed with this build.
      
      If you are trying to create a single distribution with multiple packages
      on purpose, you should not rely on automatic discovery.
      Instead, consider the following options:
      
      1. set up custom discovery (`find` directive with `include` or `exclude`)
      2. use a `src-layout`
      3. explicitly set `py_modules` or `packages` with a list of names
  1. need to change how we tag to make versioningit happy
  2. need to fix something related to the package layout

setup.py Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hooray!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

setup.py gone!

Copy link

codecov bot commented Nov 11, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a0f8ece) 98.33% compared to head (a64fcca) 98.30%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #65      +/-   ##
==========================================
- Coverage   98.33%   98.30%   -0.03%     
==========================================
  Files           2        2              
  Lines          60       59       -1     
==========================================
- Hits           59       58       -1     
  Misses          1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@IAlibay
Copy link
Collaborator Author

IAlibay commented Nov 19, 2023

@orbeckst I think this is good to go?

Copy link
Member

@orbeckst orbeckst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks. There are two empty offset lock files checked in. Should they be included?

propkatraj/tests/data/.atterr_frame1.xtc_offsets.lock Outdated Show resolved Hide resolved
propkatraj/tests/data/.indexerr_frame14.xtc_offsets.lock Outdated Show resolved Hide resolved
@IAlibay IAlibay requested a review from orbeckst December 23, 2023 15:50
@IAlibay
Copy link
Collaborator Author

IAlibay commented Dec 23, 2023

This should be good to go for now @orbeckst - next up let's aim for the latest propka release!

@orbeckst
Copy link
Member

Cheers and yes!

@IAlibay IAlibay merged commit 13b7ec5 into main Dec 23, 2023
24 checks passed
@IAlibay IAlibay deleted the spruce-up branch December 23, 2023 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants