-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update for versioningit and stuff #65
Conversation
CI hasn't been running for a long while, let's see what happens... |
Thanks for starting the work. For reference I am copying the current failures from setuptools:
|
setup.py
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hooray!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
setup.py gone!
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #65 +/- ##
==========================================
- Coverage 98.33% 98.30% -0.03%
==========================================
Files 2 2
Lines 60 59 -1
==========================================
- Hits 59 58 -1
Misses 1 1 ☔ View full report in Codecov by Sentry. |
@orbeckst I think this is good to go? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many thanks. There are two empty offset lock files checked in. Should they be included?
This should be good to go for now @orbeckst - next up let's aim for the latest propka release! |
Cheers and yes! |
No description provided.