-
Notifications
You must be signed in to change notification settings - Fork 55
Developer Guide
Oliver Beckstein edited this page Aug 9, 2018
·
2 revisions
Overview over the development process of GromacsWrapper. (The developer guide is an evolving document. Please modify as necessary.)
Development happens on the master branch. The master branch is supposed to be installable and produce correct results at any time. Therefore, tests are required.
- We use a Pull Request, Review, Merge model for code development with continuous integration: code can only be added to master through a PR. The PR has to pass
- code review by another developer with write access to the repo
- unit tests (all existing tests pass)
- coverage testing (new code comes with tests to check the majority of its functionality)
- For each PR, the whole test suite is run (on Travis CI). If your PR does not pass tests then it will typically not be accepted. Ask for help (ping other developers with @NAME mentioning them in the comments of your PR).
- PRs are typically merged (or rebased onto master) but sometimes the developer in charge can also decide to squash all commits (especially when there are many incremental commits) in order to keep the history clean.
Fork the repository and create a PR or, if you have write access to the repo, create a branch in the repo. Name the branch issue-XXX-SUMMARY where you typically reference an issue in the issue tracker and SUMMARY is a very short description.
Discuss all issues related to a PR in the comments to the PR.