Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

langs #90

Merged
merged 2 commits into from
Oct 8, 2024
Merged

langs #90

merged 2 commits into from
Oct 8, 2024

Conversation

N6REJ
Copy link
Contributor

@N6REJ N6REJ commented Oct 7, 2024

User description

fixes Bearsampp/Bearsampp#458


PR Type

enhancement, bug_fix


Description

  • Updated language files for Hungarian, French, German, and Swedish translations to improve readability by adjusting line breaks.
  • Corrected the action title in the Hungarian language file from "Switch version" to "Switch PHP setting".
  • Fixed syntax errors in the Spanish language file by adding missing quotation marks.

Changes walkthrough 📝

Relevant files
Enhancement
french.lang
Update French translation for better readability                 

core/langs/french.lang

  • Improved line break placement in the aboutText string.
+1/-1     
german.lang
Update German translation for better readability                 

core/langs/german.lang

  • Improved line break placement in the aboutText string.
+1/-1     
hungarian.lang
Update Hungarian translation and correct action title       

core/langs/hungarian.lang

  • Corrected the action title from "Switch version" to "Switch PHP
    setting".
  • Improved line break placement in the aboutText string.
  • +2/-2     
    swedish.lang
    Update Swedish translation for better readability               

    core/langs/swedish.lang

    • Improved line break placement in the aboutText string.
    +1/-1     
    Bug fix
    spanish.lang
    Fix syntax errors in Spanish translation                                 

    core/langs/spanish.lang

    • Fixed syntax errors by adding missing quotation marks.
    +2/-2     

    💡 PR-Agent usage: Comment /help "your question" on any pull request to receive relevant information

    @N6REJ N6REJ added the Bug fix label Oct 7, 2024
    @qodo-merge-pro qodo-merge-pro bot added enhancement New feature or request bug_fix and removed Bug fix labels Oct 7, 2024
    Copy link

    qodo-merge-pro bot commented Oct 7, 2024

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ Recommended focus areas for review

    Translation Inconsistency
    The 'aboutText' string is still in English while other parts of the file are in Hungarian.

    Potential Typo
    The word 'Acción' in the comment on line 183 has an accent, which is inconsistent with other occurrences of 'Action' in the file.

    Copy link

    qodo-merge-pro bot commented Oct 7, 2024

    PR Code Suggestions ✨

    Explore these optional code suggestions:

    CategorySuggestion                                                                                                                                    Score
    Best practice
    Maintain consistent punctuation in error messages

    Ensure consistent use of periods at the end of sentences in error messages.

    core/langs/spanish.lang [181]

    -serviceRemoveError = "Error durante la desinstalación del servicio de %s"
    +serviceRemoveError = "Error durante la desinstalación del servicio de %s."
    • Apply this suggestion
    Suggestion importance[1-10]: 9

    Why: Adding a period at the end of the error message ensures consistency in punctuation, which is important for maintaining a professional and uniform appearance in user-facing messages.

    9
    Enhancement
    Translate the 'aboutText' content to maintain language consistency

    Translate the 'aboutText' content from English to Hungarian to maintain consistency
    with the rest of the file.

    core/langs/hungarian.lang [290]

    -aboutText = "%s@nl@Copyright(C) 2014-%s %s@nl@@nl@A Bearsampp szabad szoftver; szabadon terjesztheti és/vagy módosíthatja@nl@a GNU KISEBB ÁLTALÁNOS NYILVÁNOS LICENC feltételei szerint."
    +aboutText = "%s@nl@Copyright(C) 2014-%s %s@nl@@nl@A Bearsampp ingyenes szoftver; szabadon terjesztheti és/vagy módosíthatja@nl@a GNU LESSER GENERAL PUBLIC LICENSE feltételei szerint."
    • Apply this suggestion
    Suggestion importance[1-10]: 7

    Why: The suggestion correctly identifies that the 'aboutText' content should be translated to Hungarian for consistency with the rest of the file. This enhances readability and maintains linguistic uniformity.

    7

    💡 Need additional feedback ? start a PR chat

    @jwaisner jwaisner merged commit 681b70d into main Oct 8, 2024
    1 check passed
    @jwaisner jwaisner deleted the langs branch October 8, 2024 01:02
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    "About" PopUp with french language
    2 participants