Fix kwargs/args untyped (#1049)

--------- Co-authored-by: ᑕᗩᑭTᗩIᑎᗰᗩᖇᐯᗴᒪ <[email protected]>
BeanieODM · Oct 15, 2024 · f9d79ff · f9d79ff
1 parent 3421d55
commit f9d79ff
Show file tree

Hide file tree

Showing 16 changed files with 89 additions and 85 deletions.
diff --git a/beanie/executors/migrate.py b/beanie/executors/migrate.py
@@ -18,7 +18,7 @@
 
 
 class MigrationSettings:
-    def __init__(self, **kwargs):
+    def __init__(self, **kwargs: Any):
         self.direction = (
             kwargs.get("direction")
             or self.get_env_value("direction")

diff --git a/beanie/migrations/controllers/free_fall.py b/beanie/migrations/controllers/free_fall.py
@@ -1,5 +1,5 @@
 from inspect import signature
-from typing import List, Type
+from typing import Any, List, Type
 
 from beanie.migrations.controllers.base import BaseMigrationController
 from beanie.odm.documents import Document
@@ -12,7 +12,7 @@ def __init__(self, function):
             self.function_signature = signature(function)
             self.document_models = document_models
 
-        def __call__(self, *args, **kwargs):
+        def __call__(self, *args: Any, **kwargs: Any):
             pass
 
         @property

diff --git a/beanie/migrations/controllers/iterative.py b/beanie/migrations/controllers/iterative.py
@@ -1,6 +1,6 @@
 import asyncio
 from inspect import isclass, signature
-from typing import List, Optional, Type, Union
+from typing import Any, List, Optional, Type, Union
 
 from beanie.migrations.controllers.base import BaseMigrationController
 from beanie.migrations.utils import update_dict
@@ -77,7 +77,7 @@ def __init__(self, function):
 
             self.batch_size = batch_size
 
-        def __call__(self, *args, **kwargs):
+        def __call__(self, *args: Any, **kwargs: Any):
             pass
 
         @property

diff --git a/beanie/odm/documents.py b/beanie/odm/documents.py
@@ -204,7 +204,7 @@ class Config:
     # Database
     _database_major_version: ClassVar[int] = 4
 
-    def __init__(self, *args, **kwargs) -> None:
+    def __init__(self, *args: Any, **kwargs: Any) -> None:
         super(Document, self).__init__(*args, **kwargs)
         self.get_motor_collection()
 
@@ -254,7 +254,7 @@ async def get(
         with_children: bool = False,
         nesting_depth: Optional[int] = None,
         nesting_depths_per_field: Optional[Dict[str, int]] = None,
-        **pymongo_kwargs,
+        **pymongo_kwargs: Any,
     ) -> Optional["DocType"]:
         """
         Get document by id, returns None if document does not exist
@@ -436,7 +436,7 @@ async def insert_many(
         documents: Iterable[DocType],
         session: Optional[AsyncIOMotorClientSession] = None,
         link_rule: WriteRules = WriteRules.DO_NOTHING,
-        **pymongo_kwargs,
+        **pymongo_kwargs: Any,
     ) -> InsertManyResult:
         """
         Insert many documents to the collection
@@ -553,7 +553,7 @@ async def save(
         session: Optional[AsyncIOMotorClientSession] = None,
         link_rule: WriteRules = WriteRules.DO_NOTHING,
         ignore_revision: bool = False,
-        **kwargs,
+        **kwargs: Any,
     ) -> Self:
         """
         Update an existing model in the database or
@@ -691,13 +691,13 @@ async def replace_many(
     @save_state_after
     async def update(
         self: Self,
-        *args,
+        *args: Union[Dict[Any, Any], Mapping[Any, Any]],
         ignore_revision: bool = False,
         session: Optional[AsyncIOMotorClientSession] = None,
         bulk_writer: Optional[BulkWriter] = None,
         skip_actions: Optional[List[Union[ActionDirections, str]]] = None,
         skip_sync: Optional[bool] = None,
-        **pymongo_kwargs,
+        **pymongo_kwargs: Any,
     ) -> Self:
         """
         Partially update the document in the database
@@ -709,7 +709,7 @@ async def update(
         :param pymongo_kwargs: pymongo native parameters for update operation
         :return: self
         """
-        arguments = list(args)
+        arguments: list[Any] = list(args)
 
         if skip_sync is not None:
             raise DeprecationWarning(
@@ -750,7 +750,7 @@ def update_all(
         *args: Union[dict, Mapping],
         session: Optional[AsyncIOMotorClientSession] = None,
         bulk_writer: Optional[BulkWriter] = None,
-        **pymongo_kwargs,
+        **pymongo_kwargs: Any,
     ) -> UpdateMany:
         """
         Partially update all the documents
@@ -771,7 +771,7 @@ def set(
         session: Optional[AsyncIOMotorClientSession] = None,
         bulk_writer: Optional[BulkWriter] = None,
         skip_sync: Optional[bool] = None,
-        **kwargs,
+        **kwargs: Any,
     ) -> Coroutine[None, None, Self]:
         """
         Set values
@@ -810,7 +810,7 @@ def current_date(
         session: Optional[AsyncIOMotorClientSession] = None,
         bulk_writer: Optional[BulkWriter] = None,
         skip_sync: Optional[bool] = None,
-        **kwargs,
+        **kwargs: Any,
     ) -> Coroutine[None, None, Self]:
         """
         Set current date
@@ -837,7 +837,7 @@ def inc(
         session: Optional[AsyncIOMotorClientSession] = None,
         bulk_writer: Optional[BulkWriter] = None,
         skip_sync: Optional[bool] = None,
-        **kwargs,
+        **kwargs: Any,
     ) -> Coroutine[None, None, Self]:
         """
         Increment
@@ -876,7 +876,7 @@ async def delete(
         bulk_writer: Optional[BulkWriter] = None,
         link_rule: DeleteRules = DeleteRules.DO_NOTHING,
         skip_actions: Optional[List[Union[ActionDirections, str]]] = None,
-        **pymongo_kwargs,
+        **pymongo_kwargs: Any,
     ) -> Optional[DeleteResult]:
         """
         Delete the document
@@ -931,7 +931,7 @@ async def delete_all(
         cls,
         session: Optional[AsyncIOMotorClientSession] = None,
         bulk_writer: Optional[BulkWriter] = None,
-        **pymongo_kwargs,
+        **pymongo_kwargs: Any,
     ) -> Optional[DeleteResult]:
         """
         Delete all the documents
@@ -1161,7 +1161,7 @@ def _check_hidden_fields(cls):
                 cls.__exclude_fields__[name] = True
 
     @wrap_with_actions(event_type=EventTypes.VALIDATE_ON_SAVE)
-    async def validate_self(self, *args, **kwargs):
+    async def validate_self(self, *args: Any, **kwargs: Any):
         # TODO: it can be sync, but needs some actions controller improvements
         if self.get_settings().validate_on_save:
             new_model = parse_model(self.__class__, get_model_dump(self))
@@ -1227,7 +1227,7 @@ async def hard_delete(
         bulk_writer: Optional[BulkWriter] = None,
         link_rule: DeleteRules = DeleteRules.DO_NOTHING,
         skip_actions: Optional[List[Union[ActionDirections, str]]] = None,
-        **pymongo_kwargs,
+        **pymongo_kwargs: Any,
     ) -> Optional[DeleteResult]:
         return await super().delete(
             session=session,
@@ -1264,7 +1264,7 @@ def find_many_in_all(  # type: ignore
         lazy_parse: bool = False,
         nesting_depth: Optional[int] = None,
         nesting_depths_per_field: Optional[Dict[str, int]] = None,
-        **pymongo_kwargs,
+        **pymongo_kwargs: Any,
     ) -> Union[FindMany[FindType], FindMany["DocumentProjectionType"]]:
         return cls._find_many_query_class(document_model=cls).find_many(
             *args,
@@ -1296,7 +1296,7 @@ def find_many(  # type: ignore
         lazy_parse: bool = False,
         nesting_depth: Optional[int] = None,
         nesting_depths_per_field: Optional[Dict[str, int]] = None,
-        **pymongo_kwargs,
+        **pymongo_kwargs: Any,
     ) -> Union[FindMany[FindType], FindMany["DocumentProjectionType"]]:
         args = cls._add_class_id_filter(args, with_children) + (
             {"deleted_at": None},
@@ -1327,7 +1327,7 @@ def find_one(  # type: ignore
         with_children: bool = False,
         nesting_depth: Optional[int] = None,
         nesting_depths_per_field: Optional[Dict[str, int]] = None,
-        **pymongo_kwargs,
+        **pymongo_kwargs: Any,
     ) -> Union[FindOne[FindType], FindOne["DocumentProjectionType"]]:
         args = cls._add_class_id_filter(args, with_children) + (
             {"deleted_at": None},

diff --git a/beanie/odm/fields.py b/beanie/odm/fields.py
@@ -84,7 +84,7 @@ class IndexedAnnotation:
     _indexed: Tuple[int, Dict[str, Any]]
 
 
-def Indexed(typ=None, index_type=ASCENDING, **kwargs):
+def Indexed(typ=None, index_type=ASCENDING, **kwargs: Any):
     """
     If `typ` is defined, returns a subclass of `typ` with an extra attribute
     `_indexed` as a tuple:
@@ -109,7 +109,7 @@ class MyModel(BaseModel):
     class NewType(typ):
         _indexed = (index_type, kwargs)
 
-        def __new__(cls, *args, **kwargs):
+        def __new__(cls, *args: Any, **kwargs: Any):
             return typ.__new__(typ, *args, **kwargs)
 
         if IS_PYDANTIC_V2:

diff --git a/beanie/odm/interfaces/aggregate.py b/beanie/odm/interfaces/aggregate.py
@@ -25,7 +25,7 @@ def aggregate(
         projection_model: None = None,
         session: Optional[AsyncIOMotorClientSession] = None,
         ignore_cache: bool = False,
-        **pymongo_kwargs,
+        **pymongo_kwargs: Any,
     ) -> AggregationQuery[Dict[str, Any]]: ...
 
     @overload
@@ -36,7 +36,7 @@ def aggregate(
         projection_model: Type[DocumentProjectionType],
         session: Optional[AsyncIOMotorClientSession] = None,
         ignore_cache: bool = False,
-        **pymongo_kwargs,
+        **pymongo_kwargs: Any,
     ) -> AggregationQuery[DocumentProjectionType]: ...
 
     @classmethod
@@ -46,7 +46,7 @@ def aggregate(
         projection_model: Optional[Type[DocumentProjectionType]] = None,
         session: Optional[AsyncIOMotorClientSession] = None,
         ignore_cache: bool = False,
-        **pymongo_kwargs,
+        **pymongo_kwargs: Any,
     ) -> Union[
         AggregationQuery[Dict[str, Any]],
         AggregationQuery[DocumentProjectionType],

diff --git a/beanie/odm/interfaces/aggregation_methods.py b/beanie/odm/interfaces/aggregation_methods.py
@@ -16,7 +16,7 @@ def aggregate(
         self,
         aggregation_pipeline,
         projection_model=None,
-        session=None,
+        session: Optional[AsyncIOMotorClientSession] = None,
         ignore_cache: bool = False,
     ): ...
 

diff --git a/beanie/odm/interfaces/find.py b/beanie/odm/interfaces/find.py
@@ -66,7 +66,7 @@ def find_one(  # type: ignore
         with_children: bool = False,
         nesting_depth: Optional[int] = None,
         nesting_depths_per_field: Optional[Dict[str, int]] = None,
-        **pymongo_kwargs,
+        **pymongo_kwargs: Any,
     ) -> FindOne[FindType]: ...
 
     @overload
@@ -81,7 +81,7 @@ def find_one(  # type: ignore
         with_children: bool = False,
         nesting_depth: Optional[int] = None,
         nesting_depths_per_field: Optional[Dict[str, int]] = None,
-        **pymongo_kwargs,
+        **pymongo_kwargs: Any,
     ) -> FindOne["DocumentProjectionType"]: ...
 
     @classmethod
@@ -95,7 +95,7 @@ def find_one(  # type: ignore
         with_children: bool = False,
         nesting_depth: Optional[int] = None,
         nesting_depths_per_field: Optional[Dict[str, int]] = None,
-        **pymongo_kwargs,
+        **pymongo_kwargs: Any,
     ) -> Union[FindOne[FindType], FindOne["DocumentProjectionType"]]:
         """
         Find one document by criteria.
@@ -137,7 +137,7 @@ def find_many(  # type: ignore
         lazy_parse: bool = False,
         nesting_depth: Optional[int] = None,
         nesting_depths_per_field: Optional[Dict[str, int]] = None,
-        **pymongo_kwargs,
+        **pymongo_kwargs: Any,
     ) -> FindMany[FindType]: ...
 
     @overload
@@ -156,7 +156,7 @@ def find_many(  # type: ignore
         lazy_parse: bool = False,
         nesting_depth: Optional[int] = None,
         nesting_depths_per_field: Optional[Dict[str, int]] = None,
-        **pymongo_kwargs,
+        **pymongo_kwargs: Any,
     ) -> FindMany["DocumentProjectionType"]: ...
 
     @classmethod
@@ -174,7 +174,7 @@ def find_many(  # type: ignore
         lazy_parse: bool = False,
         nesting_depth: Optional[int] = None,
         nesting_depths_per_field: Optional[Dict[str, int]] = None,
-        **pymongo_kwargs,
+        **pymongo_kwargs: Any,
     ) -> Union[FindMany[FindType], FindMany["DocumentProjectionType"]]:
         """
         Find many documents by criteria.
@@ -223,7 +223,7 @@ def find(  # type: ignore
         lazy_parse: bool = False,
         nesting_depth: Optional[int] = None,
         nesting_depths_per_field: Optional[Dict[str, int]] = None,
-        **pymongo_kwargs,
+        **pymongo_kwargs: Any,
     ) -> FindMany[FindType]: ...
 
     @overload
@@ -242,7 +242,7 @@ def find(  # type: ignore
         lazy_parse: bool = False,
         nesting_depth: Optional[int] = None,
         nesting_depths_per_field: Optional[Dict[str, int]] = None,
-        **pymongo_kwargs,
+        **pymongo_kwargs: Any,
     ) -> FindMany["DocumentProjectionType"]: ...
 
     @classmethod
@@ -260,7 +260,7 @@ def find(  # type: ignore
         lazy_parse: bool = False,
         nesting_depth: Optional[int] = None,
         nesting_depths_per_field: Optional[Dict[str, int]] = None,
-        **pymongo_kwargs,
+        **pymongo_kwargs: Any,
     ) -> Union[FindMany[FindType], FindMany["DocumentProjectionType"]]:
         """
         The same as find_many
@@ -295,7 +295,7 @@ def find_all(  # type: ignore
         lazy_parse: bool = False,
         nesting_depth: Optional[int] = None,
         nesting_depths_per_field: Optional[Dict[str, int]] = None,
-        **pymongo_kwargs,
+        **pymongo_kwargs: Any,
     ) -> FindMany[FindType]: ...
 
     @overload
@@ -312,7 +312,7 @@ def find_all(  # type: ignore
         lazy_parse: bool = False,
         nesting_depth: Optional[int] = None,
         nesting_depths_per_field: Optional[Dict[str, int]] = None,
-        **pymongo_kwargs,
+        **pymongo_kwargs: Any,
     ) -> FindMany["DocumentProjectionType"]: ...
 
     @classmethod
@@ -328,7 +328,7 @@ def find_all(  # type: ignore
         lazy_parse: bool = False,
         nesting_depth: Optional[int] = None,
         nesting_depths_per_field: Optional[Dict[str, int]] = None,
-        **pymongo_kwargs,
+        **pymongo_kwargs: Any,
     ) -> Union[FindMany[FindType], FindMany["DocumentProjectionType"]]:
         """
         Get all the documents
@@ -370,7 +370,7 @@ def all(  # type: ignore
         lazy_parse: bool = False,
         nesting_depth: Optional[int] = None,
         nesting_depths_per_field: Optional[Dict[str, int]] = None,
-        **pymongo_kwargs,
+        **pymongo_kwargs: Any,
     ) -> FindMany[FindType]: ...
 
     @overload
@@ -387,7 +387,7 @@ def all(  # type: ignore
         lazy_parse: bool = False,
         nesting_depth: Optional[int] = None,
         nesting_depths_per_field: Optional[Dict[str, int]] = None,
-        **pymongo_kwargs,
+        **pymongo_kwargs: Any,
     ) -> FindMany["DocumentProjectionType"]: ...
 
     @classmethod
@@ -403,7 +403,7 @@ def all(  # type: ignore
         lazy_parse: bool = False,
         nesting_depth: Optional[int] = None,
         nesting_depths_per_field: Optional[Dict[str, int]] = None,
-        **pymongo_kwargs,
+        **pymongo_kwargs: Any,
     ) -> Union[FindMany[FindType], FindMany["DocumentProjectionType"]]:
         """
         the same as find_all