Make Delphi Happy, about those conditionals #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Can't understand why in earth delphi even cares of second condition because of {$if defined(fpc) and should be enough, if thee is plau >=3 then Delphi complains with : [dcc32 Warning] FLRE.pas(5493): W1023 Comparing signed and unsigned types - widened both operands, hope this works OK in the FPC also
|
It fixes the previous issue I posted: #76 |
|
Nope, FPC raises then a error then, at least stable FPC versions, while it seems to be fixed in the non-stable FPC dev version. Thus, I would wait here until FPC >=3.4 as stable version will be released, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Can't understand why in earth delphi even cares of second condition because of "{$if defined(fpc) and" should be enough,
If there is plane ">=3" then Delphi complains with :
[dcc32 Warning] FLRE.pas(5493): W1023 Comparing signed and unsigned types - widened both operands
hope this works OK in the FPC also