Add Github workflow for checking PHP quality #2
Conversation
petitphp
force-pushed
the
feature/github-workflows
branch
from
c309e1d to
a326065
Compare
.github/workflows/quality-js.yml
Outdated
| checks: | ||
| name: Lint JS | ||
| runs-on: ubuntu-latest | ||
| if: ${{ github.repository == 'BeAPI/multisite-shared-blocks' || github.event_name == 'pull_request' }} |
There was a problem hiding this comment.
Pourquoi tester le nom du repo ? ou l'event name ?
La condition au dessus devrait suffire
There was a problem hiding this comment.
C'est repris de ce que fait WordPress ou Yoast dans ses workflows. Je crois que c'est une sécurité en cas ou une personne fork un projet.
There was a problem hiding this comment.
Ah ok, inutile à notre échelle je pense.
There was a problem hiding this comment.
Pour référence : WordPress/gutenberg#32114
.github/workflows/quality-php.yml
Outdated
| checks: | ||
| name: Codesniffer | ||
| runs-on: ubuntu-latest | ||
| if: ${{ github.repository == 'BeAPI/multisite-shared-blocks' || github.event_name == 'pull_request' }} |
There was a problem hiding this comment.
Pourquoi tester le nom du repo ? ou l'event name ?
La condition au dessus devrait suffire
.github/workflows/unit-tests.yml
Outdated
| unit-php: | ||
| name: PHP | ||
| runs-on: ubuntu-latest | ||
| if: ${{ github.repository == 'BeAPI/multisite-shared-blocks' || github.event_name == 'pull_request' }} |
There was a problem hiding this comment.
Pourquoi tester le nom du repo ? ou l'event name ?
La condition au dessus devrait suffire
.github/workflows/unit-tests.yml
Outdated
|
|
||
| - name: Run unit tests | ||
| run: npm run test:php | ||
| if: ${{ success() || failure() }} |
There was a problem hiding this comment.
Pas compris l'intéret de la ligne, si la commande plante alors l'action sera considérée comme fausse et donc OK.
There was a problem hiding this comment.
C'est repris de ce que fait Gutenberg dans son workflow. Je peux tester sans.
There was a problem hiding this comment.
Bah là ça dit que ça passe que se soit une erreur ou un succès, ça me parait chelou, laissons-le échouer si besoin
.github/workflows/quality-js.yml
Outdated
| checks: | ||
| name: Lint JS | ||
| runs-on: ubuntu-latest | ||
| if: ${{ github.repository == 'BeAPI/multisite-shared-blocks' || github.event_name == 'pull_request' }} |
There was a problem hiding this comment.
Ah ok, inutile à notre échelle je pense.
.github/workflows/unit-tests.yml
Outdated
|
|
||
| - name: Run unit tests | ||
| run: npm run test:php | ||
| if: ${{ success() || failure() }} |
There was a problem hiding this comment.
Bah là ça dit que ça passe que se soit une erreur ou un succès, ça me parait chelou, laissons-le échouer si besoin
petitphp
force-pushed
the
feature/github-workflows
branch
from
5552526 to
3cbbd56
Compare
No description provided.