forked from UDST/bayarea_urbansim
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feasibility Staleness hotfix #382
Open
akselx
wants to merge
26
commits into
main
Choose a base branch
from
feasibility_repeat_fix
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a few inline comments on how to treat perhaps useful `task_name` argument
Merge branch 'meta_changes' of https://github.com/BayAreaMetro/bayarea_urbansim into meta_changes
…ck notification with link to task
Added function to get git branch and commit hash to run inventory
…r from the baus runtime. Data from BAUS run_setup.yaml
… test non_residential_sqft overcount
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch is a hotfix for a stale feasiblity.
The issue is that a parcel may be feasible for multiple buildings - and may be assigned a residential building in
residential_developer()
only to be found feasible for a large retail project later, inretail_developer()
. In practice, this joint allocation is unlikely, and should be handled only through explicit mixed use development forms.Since the feasibility step is run before the first developer model step (residential) in a year's simulation cycle, it predates the placement of a building in the residential developer.
This fix re-runs the feasibility step before each developer model type.
The fix is implemented as:
baus.py
Since this branch is built on top of #379 that PR should be merged first.