Prepend a static prefix to cache keys

Baune8D · Oct 17, 2017 · 1413f02 · 1413f02
1 parent 698d6f2
commit 1413f02
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 13 deletions.
diff --git a/src/ExpressionCache.Core/ExpressionCacheBase.cs b/src/ExpressionCache.Core/ExpressionCacheBase.cs
@@ -8,6 +8,8 @@ namespace ExpressionCache.Core
 {
     public abstract class ExpressionCacheBase : IExpressionCacheBase
     {
+        public const string CachePrefix = "ExprCache";
+
         private readonly IMemoryCache _internalCache;
 
         protected IExpressionCacheProvider Provider { get; }
@@ -127,7 +129,7 @@ private static string GenerateBaseCacheKey(MethodCallExpression methodCall, Meth
                 .By(methodInfo.Name)
                 .By(methodInfo.GetGenericArguments());
 
-            return keyBuilder.ToString();
+            return CachePrefix + keyBuilder;
         }
 
         private static string GenerateCacheKey(string baseKey, object[] arguments)

diff --git a/test/ExpressionCache.Core.Tests/ExpressionCacheBaseTests.cs b/test/ExpressionCache.Core.Tests/ExpressionCacheBaseTests.cs
@@ -24,14 +24,14 @@ public void GetKey_FunctionWithoutParameters_ShouldReturnCacheKeyString()
                 var key = fixture.ExpressionCacheBase.GetKey(() => _testFunctions.FunctionWithoutParameters());
                 var asyncKey = fixture.ExpressionCacheBase.GetKey(() => _testFunctions.FunctionWithoutParametersAsync());
 
-                key.ShouldBe(
+                key.ShouldBe(CacheKeyHelper.Prefix(
                     CacheKeyHelper.Format(_testFunctions.ClassName) +
                     CacheKeyHelper.Format(nameof(_testFunctions.FunctionWithoutParameters))
-                );
-                asyncKey.ShouldBe(
+                ));
+                asyncKey.ShouldBe(CacheKeyHelper.Prefix(
                     CacheKeyHelper.Format(_testFunctions.ClassName) +
                     CacheKeyHelper.Format(nameof(_testFunctions.FunctionWithoutParametersAsync))
-                );
+                ));
             }
         }
 
@@ -45,16 +45,16 @@ public void GetKey_FunctionWithOneParameter_ShouldReturnCacheKeyString()
                 var key = fixture.ExpressionCacheBase.GetKey(() => _testFunctions.FunctionWithOneParameter(parameter));
                 var asyncKey = fixture.ExpressionCacheBase.GetKey(() => _testFunctions.FunctionWithOneParameterAsync(parameter));
 
-                key.ShouldBe(
+                key.ShouldBe(CacheKeyHelper.Prefix(
                     CacheKeyHelper.Format(_testFunctions.ClassName) +
                     CacheKeyHelper.Format(nameof(_testFunctions.FunctionWithOneParameter)) +
                     CacheKeyHelper.Format(parameter)
-                );
-                asyncKey.ShouldBe(
+                ));
+                asyncKey.ShouldBe(CacheKeyHelper.Prefix(
                     CacheKeyHelper.Format(_testFunctions.ClassName) +
                     CacheKeyHelper.Format(nameof(_testFunctions.FunctionWithOneParameterAsync)) +
                     CacheKeyHelper.Format(parameter)
-                );
+                ));
             }
         }
 
@@ -69,18 +69,18 @@ public void GetKey_FunctionWithTwoParameters_ShouldReturnCacheKeyString()
                 var key = fixture.ExpressionCacheBase.GetKey(() => _testFunctions.FunctionWithTwoParameters(parameterOne, parameterTwo));
                 var asyncKey = fixture.ExpressionCacheBase.GetKey(() => _testFunctions.FunctionWithTwoParametersAsync(parameterOne, parameterTwo));
 
-                key.ShouldBe(
+                key.ShouldBe(CacheKeyHelper.Prefix(
                     CacheKeyHelper.Format(_testFunctions.ClassName) +
                     CacheKeyHelper.Format(nameof(_testFunctions.FunctionWithTwoParameters)) +
                     CacheKeyHelper.Format(parameterOne) +
                     CacheKeyHelper.Format(parameterTwo)
-                );
-                asyncKey.ShouldBe(
+                ));
+                asyncKey.ShouldBe(CacheKeyHelper.Prefix(
                     CacheKeyHelper.Format(_testFunctions.ClassName) +
                     CacheKeyHelper.Format(nameof(_testFunctions.FunctionWithTwoParametersAsync)) +
                     CacheKeyHelper.Format(parameterOne) +
                     CacheKeyHelper.Format(parameterTwo)
-                );
+                ));
             }
         }
 

diff --git a/test/ExpressionCache.Core.Tests/TestHelpers/CacheKeyHelper.cs b/test/ExpressionCache.Core.Tests/TestHelpers/CacheKeyHelper.cs
@@ -2,6 +2,11 @@
 {
     public static class CacheKeyHelper
     {
+        public static string Prefix(string key)
+        {
+            return ExpressionCacheBase.CachePrefix + key;
+        }
+
         public static string Format<TResult>(TResult value)
         {
             return "{" + value + "}";