Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEV 953: Add basic maps support to CLI #74

Merged
merged 6 commits into from
May 25, 2022
Merged

Conversation

robbles
Copy link
Contributor

@robbles robbles commented May 21, 2022

This allows using a pre-configured map when running games via battlesnake play.

This PR also cleans up a couple of things:

  • remove squad support and switch to using pipelines only in RulesBuilder
  • refactor play command to remove global variables and fix a few bugs
  • fixes a bug in the new map version of Royale where food wasn't generated after turn zero

@codecov-commenter
Copy link

codecov-commenter commented May 24, 2022

Codecov Report

Merging #74 (85f593e) into main (2d83420) will decrease coverage by 2.87%.
The diff coverage is 38.24%.

@@            Coverage Diff             @@
##             main      #74      +/-   ##
==========================================
- Coverage   66.89%   64.01%   -2.88%     
==========================================
  Files          21       20       -1     
  Lines        1169     1095      -74     
==========================================
- Hits          782      701      -81     
- Misses        372      374       +2     
- Partials       15       20       +5     
Impacted Files Coverage Δ
cli/commands/root.go 11.11% <0.00%> (-0.66%) ⬇️
client/models.go 0.00% <ø> (ø)
constants.go 100.00% <ø> (ø)
maps/game_map.go 100.00% <ø> (ø)
pipeline.go 100.00% <ø> (ø)
solo.go 83.33% <ø> (ø)
wrapped.go 80.95% <ø> (-4.77%) ⬇️
cli/commands/play.go 18.38% <28.72%> (-4.24%) ⬇️
maps/royale.go 48.38% <50.00%> (+44.93%) ⬆️
ruleset.go 88.05% <86.66%> (-1.74%) ⬇️
... and 13 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@robbles robbles changed the base branch from main to dev-1310-update-int-types May 25, 2022 18:07
Base automatically changed from dev-1310-update-int-types to main May 25, 2022 18:17
@robbles robbles merged commit 1adbc79 into main May 25, 2022
@robbles robbles deleted the DEV-953-add-maps-to-cli branch May 25, 2022 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants