Castle Wall Hazard Map #101

bcambl · 2022-08-14T04:30:13Z

Castle Wall Map

Gameplay Notes

All snakes start outside of the walls.
Food only spawns on the bridges and only one food can spawn per bridge at a time on larger boards (double walls)
Crossing bridges should be handled with caution as the hazard on either side is double layered.
Food does not spawn for the first 10 turns with only 2-4 food thereafter based on board size.
--hazardDamagePerTurn 50 will require snakes to commit to crossing the bridges and/or collecting food.

Support Matrix

Board Size	Max Snakes	Max Food
11x11	8	2 (turn 10+)
19x19	8	2 (turn 10+)
25x25	12	4 (turn 10+)

Board Examples

11x11

19x19

25x25

Thoughts/Concerns/Discussions

All maps will spawn snakes in the corner positions first. Should the first 4 snakes be placed near the bridges first instead?
Map could support more snakes by adding spawns inside the castle but deviates from the idea of all snakes starting outside.
All starting positions, hazards, and food are static and therefore opted for static assignment (with help from community developed tools) for performance vs generated by code.

Open to any/all suggestions or feedback from the team and community.

EDIT: Removed uninteresting map sizes and refactored PR to align with work completed in #103

Wall of hazards around the board with dangerous bridges. - add support for all standard board sizes - hazard placement for all board sizes

support 12 snakes on XLarge and XXLarge board sizes

no food in the first 10 turns

bvanvugt · 2022-08-14T04:44:35Z

@bcambl Ooooo, this is a fun one!

bcambl · 2022-08-22T22:20:07Z

Marked as wip while reorganizing into individual map sizes.

chris-bsnake · 2022-08-24T22:04:02Z

maps/castle_wall.go

+	}
+
+	// only support 8 or less snakes on boards smaller than XLarge
+	if (len(initialBoardState.Snakes) > 8) && (initialBoardState.Width < rules.BoardSizeXLarge) {


I think you could pass in the maximum allowed snakes as a parameter for the function and just do one check and then have each map provide a value that is associated with the map. I would try my best to keep setupCastleWallBoard relatively independent of board size, you can handle that logic in the different maps themselves.

Then you can just have one check that returns ErrorTooManySnakes

chris-bsnake · 2022-08-24T22:06:16Z

maps/castle_wall.go

+	}
+
+	// add positions 9-12 for xlarge board size
+	if (initialBoardState.Width >= rules.BoardSizeXLarge) && (len(initialBoardState.Snakes) > 8) {


much like above, could you pass in the set of starting positions to use into this function and have the CastleWallExtraLargeHazardsMap do this check and pass in the expanded set of starting positions? That way this function just has to use the start positions it is given

chris-bsnake · 2022-08-24T22:07:08Z

maps/castle_wall.go

+		return nil
+	}
+
+	// max of 2 food on medium & large board


Same concept as above, pass in the max food as a parameter since it seems to be linked to map size, and just do one if statement

chris-bsnake · 2022-08-24T22:09:25Z

maps/castle_wall.go

+
+	rand := settings.GetRand(lastBoardState.Turn)
+
+	rand.Shuffle(len(castleWallMediumFood), func(i int, j int) {


I might be misreading it, but i'm unsure why you are using the castleWallMediumFood constant here, is it supposed to be the food array provided as a parameter to the function?

Most definitely was supposed to be food. An unfortunate side effect of a late night refactor of a refactor.

bcambl · 2022-08-25T06:04:09Z

@chris-bsnake Thank you for taking time to review this PR. I have made changes based on your feedback. Please re-review and let me know if the latest commit resolves your concerns.

robbles

@bcambl Thanks for making those changes!

I've got a couple of optional suggestions, but otherwise this is looking good! LMK what you think - I'm happy to merge this if you don't want to spend any more time on it 😄

robbles · 2022-08-25T23:46:47Z

maps/castle_wall.go

+					break snakeLoop
+				}
+			}
+		}


It looks to me like if a food overlaps with a snake body, this will still check all the existing food for collisions as well, right?
It's not a huge deal since the lists of food are relatively short and you've already made it break early when food is placed. I think this could be simplified a bit though by dropping the tileIsOccupied var and replacing the break statements with a continue to the outermost (food) loop.

I tested this and you are correct. I will re-work this section.
Same issue may also exist in arcade_maze as that is where I copied from in attempt to match the project:

rules/maps/arcade_maze.go

Line 99 in 2668788

for _, food := range foodPositions {

Yeah - I'm not that surprised that this logic came from one of the other maps 😅
We're hoping to move a lot of this common repetitive logic into the Editor object in the near future, and we can standardize on the right way to do it at that point.

robbles · 2022-08-25T23:49:28Z

maps/castle_wall.go

+	if err != nil {
+		return err
+	}
+	return nil


tiny style nitpick: This could just be

return setupCastleWallBoard(...)

(same for the other Setup/Update methods)

No problem! Funnily enough, I actually switched to the long-hand version in my previous commit for the update func to match the style of the latest rivers_and_bridges refactor.

robbles · 2022-08-25T23:58:18Z

maps/castle_wall_internal_test.go

+
+	"github.com/stretchr/testify/require"
+)
+


Totally optional as these tests work just fine:
These 3 tests all seem to have the same logic, just different values for the map, sizes, and start positions. They could probably be a single table-driven test using

t.Run(m.ID(), func(t *testing.T) {

for each map.

Agreed! I will re-write this.

- fixes forced food spawning infront of snake issue on large & xlarge maps with double walls

bcambl · 2022-08-26T15:33:38Z

@robbles @chris-bsnake this PR should be ready for another look.
Please let me know if either of you have any additional concerns as I am happy to make the changes.

robbles

Looks great! Thanks again @bcambl!

bcambl added 6 commits August 10, 2022 21:48

castle_wall map

0d41e0b

Wall of hazards around the board with dangerous bridges. - add support for all standard board sizes - hazard placement for all board sizes

passage food placement for all board sizes

8f08d3f

4 snake starting positions for all maps

c3f84a1

only one food can spawn on a bridge

bd3746c

support 8 snakes for all board sizes

08ea882

support 12 snakes on XLarge and XXLarge board sizes

max 2 food sm/med/lg and max 4 food on xlg/xxlg

3d62522

no food in the first 10 turns

bcambl requested review from robbles, bvanvugt and chris-bsnake as code owners August 14, 2022 04:30

sort generated hazard positions

9e270fd

bcambl changed the title ~~Castle wall map~~ wip - Castle wall map Aug 22, 2022

bcambl added 3 commits August 23, 2022 21:00

Merge branch 'main' into castle_wall_map

7dc533f

remove 'uninteresting' castle wall map board sizes

80dc21a

refactor castle wall map to align with BattlesnakeOfficial#103

81fa307

bcambl changed the title ~~wip - Castle wall map~~ Castle Wall Hazard Map Aug 24, 2022

bcambl added 2 commits August 23, 2022 23:56

align map castle wall meta Name with ID

f02094e

set MinPlayers to 1 for castle wall map

b6b69be

chris-bsnake reviewed Aug 24, 2022

View reviewed changes

pass max snake/food and startPosition to priv func

36c3449

bcambl requested review from chris-bsnake and removed request for robbles and bvanvugt August 25, 2022 06:04

robbles approved these changes Aug 26, 2022

View reviewed changes

bcambl added 2 commits August 25, 2022 23:40

fix castle wall food placement and refactor tests

9b5d3ae

avoid food spawn by snake heads on castle wall map

1021285

- fixes forced food spawning infront of snake issue on large & xlarge maps with double walls

robbles approved these changes Aug 26, 2022

View reviewed changes

robbles merged commit ba3b882 into BattlesnakeOfficial:main Aug 26, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Castle Wall Hazard Map #101

Castle Wall Hazard Map #101

bcambl commented Aug 14, 2022 •

edited

Loading

bvanvugt commented Aug 14, 2022

bcambl commented Aug 22, 2022

chris-bsnake Aug 24, 2022

chris-bsnake Aug 24, 2022

chris-bsnake Aug 24, 2022

chris-bsnake Aug 24, 2022

chris-bsnake Aug 24, 2022

bcambl Aug 25, 2022

bcambl commented Aug 25, 2022

robbles left a comment

robbles Aug 25, 2022

bcambl Aug 26, 2022

robbles Aug 26, 2022

robbles Aug 25, 2022

bcambl Aug 26, 2022

robbles Aug 25, 2022

bcambl Aug 26, 2022

bcambl commented Aug 26, 2022

robbles left a comment


		rand := settings.GetRand(lastBoardState.Turn)

		rand.Shuffle(len(castleWallMediumFood), func(i int, j int) {

Castle Wall Hazard Map #101

Castle Wall Hazard Map #101

Conversation

bcambl commented Aug 14, 2022 • edited Loading

Castle Wall Map

Gameplay Notes

Support Matrix

Board Examples

11x11

19x19

25x25

Thoughts/Concerns/Discussions

bvanvugt commented Aug 14, 2022

bcambl commented Aug 22, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bcambl commented Aug 25, 2022

robbles left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bcambl commented Aug 26, 2022

robbles left a comment

Choose a reason for hiding this comment

bcambl commented Aug 14, 2022 •

edited

Loading