Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EXC_BREAKPOINT raised when stopping stream on version 2.2.3 #144

Closed
ibsus opened this issue Mar 16, 2016 · 6 comments
Closed

EXC_BREAKPOINT raised when stopping stream on version 2.2.3 #144

ibsus opened this issue Mar 16, 2016 · 6 comments

Comments

@ibsus
Copy link

ibsus commented Mar 16, 2016

EXC_BREAKPOINT is raised when we stop the stream - causing the app to crash.

within iosrtcPlugin.swift - MediaStreamTrack_stop

    dispatch_async(self.queue) {
        pluginMediaStreamTrack!.stop()    <----- EXC_BREAKPOINT crash
    }

This does not happen in version 2.2.2 of the plugin.

@ibc
Copy link
Collaborator

ibc commented Mar 18, 2016

Can you try changing the current code as follows?:

  • From:
func MediaStreamTrack_stop(command: CDVInvokedUrlCommand) {
    NSLog("iosrtcPlugin#MediaStreamTrack_stop()")

    let id = command.argumentAtIndex(0) as! String
    weak var pluginMediaStreamTrack = self.pluginMediaStreamTracks[id]
  • To:
func MediaStreamTrack_stop(command: CDVInvokedUrlCommand) {
    NSLog("iosrtcPlugin#MediaStreamTrack_stop()")

    let id = command.argumentAtIndex(0) as! String
    let pluginMediaStreamTrack = self.pluginMediaStreamTracks[id]

@ibsus
Copy link
Author

ibsus commented Mar 18, 2016

That worked. It no longer raises EXC_BREAKPOINT when closing the stream.

@ibc
Copy link
Collaborator

ibc commented Mar 18, 2016

OK, will fix it.

@ibc
Copy link
Collaborator

ibc commented Mar 18, 2016

Fixed in 21df233

@julzvilla
Copy link

Thanks for this fix. Manually changing that code seems to do the trick, but the NPM repo still seems to have the version without these changes. Will that be updated anytime soon?

@ibc
Copy link
Collaborator

ibc commented Apr 5, 2016

2.2.4 is out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants