Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow passing elements in proxy body #51

Merged
merged 1 commit into from
Mar 31, 2023
Merged

feat: allow passing elements in proxy body #51

merged 1 commit into from
Mar 31, 2023

Conversation

lcschy
Copy link
Contributor

@lcschy lcschy commented Mar 28, 2023

Description

  • Allows passing Elements in the body for proxy calls.

Testing required outside of automated testing?

  • Not Applicable

Screenshots (if appropriate):

  • Not Applicable

Rollback / Rollforward Procedure

  • Roll Forward
  • Roll Back

Reviewer Checklist

  • Description of Change
  • Description of outside testing if applicable.
  • Description of Roll Forward / Backward Procedure
  • Documentation updated for Change

@lcschy lcschy marked this pull request as ready for review March 28, 2023 18:01
@lcschy lcschy requested a review from a team as a code owner March 28, 2023 18:01
@@ -72,37 +73,6 @@ class BasisTheoryElements internal constructor(
}
}

private fun replaceElementRefs(map: MutableMap<String, Any?>): MutableMap<String, Any?> {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

moved this to DataManipulationUtils to reuse w/ proxy.

@lcschy lcschy merged commit aa92321 into master Mar 31, 2023
@lcschy lcschy deleted the eng-4408-fix branch March 31, 2023 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants