Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Parity with elements on other platforms #32

Merged
merged 7 commits into from
Jan 10, 2023
Merged

Conversation

dhudec
Copy link
Contributor

@dhudec dhudec commented Jan 8, 2023

Description

  • Adds isMaskSatisfied flag to change events
  • Changes meaning of isComplete to isMaskSatisfied && isValid to match web elements
  • Adds isMaskSatisfied, isComplete, isValid, isEmpty properties to TextElement
  • Changes card brand identifiers to match web elements (american-express, diners-club, unionpay)
  • Prevents tokenization with incomplete elements
  • Resolves ENG-4052, ENG-4046, ENG-4040, ENG-4056

Testing required outside of automated testing?

  • Not Applicable

Screenshots (if appropriate):

  • Not Applicable

Rollback / Rollforward Procedure

  • Roll Forward
  • Roll Back

Reviewer Checklist

  • Description of Change
  • Description of outside testing if applicable.
  • Description of Roll Forward / Backward Procedure
  • Documentation updated for Change

Comment on lines +22 to +23
var validDigitCounts: IntArray,
var gapCount: Int,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was a bit misleading before - validLengths meant counts of valid numbers of digits, not including the gaps, so where this was used relied upon some implicit logic to strip out non-numeric characters first. This didn't work well when checking if the mask was satisfied from TextElement to set the new isMaskSatisfied flag. Changed this to track number of gaps before passing in valid lengths into the mask.

@dhudec dhudec changed the title feat: Parity with elements on other platforms feat: Parity with elements on other platforms, resolves eng-4052, eng-4046, eng-4040, eng-4056 Jan 9, 2023
@dhudec dhudec changed the title feat: Parity with elements on other platforms, resolves eng-4052, eng-4046, eng-4040, eng-4056 feat: Parity with elements on other platforms, resolves: eng-4052, eng-4046, eng-4040, eng-4056 Jan 9, 2023
@dhudec dhudec changed the title feat: Parity with elements on other platforms, resolves: eng-4052, eng-4046, eng-4040, eng-4056 feat: Parity with elements on other platforms, resolves: ENG-4052, ENG-4046, ENG-4040, ENG-4056 Jan 9, 2023
@dhudec dhudec marked this pull request as ready for review January 9, 2023 15:08
@dhudec dhudec requested a review from a team as a code owner January 9, 2023 15:08
@dhudec dhudec changed the title feat: Parity with elements on other platforms, resolves: ENG-4052, ENG-4046, ENG-4040, ENG-4056 feat: Parity with elements on other platforms, resolves ENG-4052, ENG-4046, ENG-4040, ENG-4056 Jan 9, 2023
@dhudec dhudec changed the title feat: Parity with elements on other platforms, resolves ENG-4052, ENG-4046, ENG-4040, ENG-4056 feat: Parity with elements on other platforms Jan 9, 2023
amkera
amkera previously approved these changes Jan 9, 2023
@amkera amkera self-requested a review January 10, 2023 17:37
@dhudec dhudec merged commit eea07e6 into master Jan 10, 2023
@dhudec dhudec deleted the platform-parity branch January 10, 2023 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants