-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Parity with elements on other platforms #32
Conversation
var validDigitCounts: IntArray, | ||
var gapCount: Int, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was a bit misleading before - validLengths meant counts of valid numbers of digits, not including the gaps, so where this was used relied upon some implicit logic to strip out non-numeric characters first. This didn't work well when checking if the mask was satisfied from TextElement to set the new isMaskSatisfied
flag. Changed this to track number of gaps before passing in valid lengths into the mask.
… match web and ios
Description
Testing required outside of automated testing?
Screenshots (if appropriate):
Rollback / Rollforward Procedure
Reviewer Checklist