Renaming EventDetail types for bin and last4 to prefix with 'card' to…

… match web and ios
Basis-Theory · Jan 9, 2023 · efc5356 · efc5356
1 parent 166be50
commit efc5356
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 8 deletions.
diff --git a/lib/src/main/java/com/basistheory/android/event/ChangeEvent.kt b/lib/src/main/java/com/basistheory/android/event/ChangeEvent.kt
@@ -14,7 +14,7 @@ data class EventDetails(
 ) {
     companion object {
         const val CardBrand = "cardBrand"
-        const val Bin = "bin"
-        const val Last4 = "last4"
+        const val CardBin = "cardBin"
+        const val CardLast4 = "cardLast4"
     }
 }
diff --git a/lib/src/main/java/com/basistheory/android/view/CardNumberElement.kt b/lib/src/main/java/com/basistheory/android/view/CardNumberElement.kt
@@ -71,14 +71,14 @@ class CardNumberElement @JvmOverloads constructor(
         if (value != null && isMaskSatisfied) {
             eventDetails.add(
                 EventDetails(
-                    EventDetails.Bin,
+                    EventDetails.CardBin,
                     value.take(6)
                 )
             )
 
             eventDetails.add(
                 EventDetails(
-                    EventDetails.Last4,
+                    EventDetails.CardLast4,
                     value.takeLast(4)
                 )
             )

diff --git a/lib/src/test/java/com/basistheory/android/view/CardNumberElementTests.kt b/lib/src/test/java/com/basistheory/android/view/CardNumberElementTests.kt
@@ -134,11 +134,11 @@ class CardNumberElementTests {
                 get { message }.isEqualTo(CardBrands.VISA.label)
             }
             get { details }.any {
-                get { type }.isEqualTo(EventDetails.Bin)
+                get { type }.isEqualTo(EventDetails.CardBin)
                 get { message }.isEqualTo("411111")
             }
             get { details }.any {
-                get { type }.isEqualTo(EventDetails.Last4)
+                get { type }.isEqualTo(EventDetails.CardLast4)
                 get { message }.isEqualTo("1111")
             }
         }
@@ -160,11 +160,11 @@ class CardNumberElementTests {
                 get { message }.isEqualTo(CardBrands.VISA.label)
             }
             get { details }.any {
-                get { type }.isEqualTo(EventDetails.Bin)
+                get { type }.isEqualTo(EventDetails.CardBin)
                 get { message }.isEqualTo("424242")
             }
             get { details }.any {
-                get { type }.isEqualTo(EventDetails.Last4)
+                get { type }.isEqualTo(EventDetails.CardLast4)
                 get { message }.isEqualTo("4243")
             }
         }