Renames complete properties to isComplete to match ChangeEvent

Basis-Theory · Dec 15, 2022 · c25fc60 · c25fc60
1 parent 2b3f8f6
commit c25fc60
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 9 deletions.
diff --git a/lib/src/main/java/com/basistheory/android/service/CardBrandEnricher.kt b/lib/src/main/java/com/basistheory/android/service/CardBrandEnricher.kt
@@ -25,15 +25,15 @@ class CardBrandEnricher {
         var cardLength: Int = -1,
         var identifierLength: Int = -1,
     ) {
-        val complete: Boolean
+        val isComplete: Boolean
             get() = validLengths.contains(cardLength)
     }
 
     class CardMetadata(
         val brand: String?,
         val cvcMask: String?,
         val cardMask: String?,
-        val complete: Boolean
+        val isComplete: Boolean
     )
 
     private val cardBrands = listOf(
@@ -230,7 +230,7 @@ class CardBrandEnricher {
                 this?.brand,
                 this?.cvcMask,
                 this?.cardMask,
-                this?.complete ?: false
+                this?.isComplete ?: false
             )
         }
     }

diff --git a/lib/src/main/java/com/basistheory/android/view/CardNumberElement.kt b/lib/src/main/java/com/basistheory/android/view/CardNumberElement.kt
@@ -53,7 +53,7 @@ class CardNumberElement @JvmOverloads constructor(
         } ?: mutableListOf()
 
         return ChangeEvent(
-            cardMetadata?.complete ?: false,
+            cardMetadata?.isComplete ?: false,
             isEmpty,
             isValid,
             eventDetails

diff --git a/lib/src/test/java/com/basistheory/android/service/CardBrandEnricherTests.kt b/lib/src/test/java/com/basistheory/android/service/CardBrandEnricherTests.kt
@@ -51,14 +51,14 @@ class CardBrandEnricherTests {
     }
 
     @Test
-    fun `should set complete for best match card lengths`() {
+    fun `should set isComplete for best match card lengths`() {
         // discover valid lengths are 16 or 19
         val sixteenDigitsDiscoverCardNumber = "6582937163058334"
 
-        expectThat(cardBrandEnricher.evaluateCard(sixteenDigitsDiscoverCardNumber)?.complete).isTrue()
-        expectThat(cardBrandEnricher.evaluateCard("${sixteenDigitsDiscoverCardNumber}1")?.complete).isFalse()
-        expectThat(cardBrandEnricher.evaluateCard("${sixteenDigitsDiscoverCardNumber}12")?.complete).isFalse()
-        expectThat(cardBrandEnricher.evaluateCard("${sixteenDigitsDiscoverCardNumber}123")?.complete).isTrue()
+        expectThat(cardBrandEnricher.evaluateCard(sixteenDigitsDiscoverCardNumber)?.isComplete).isTrue()
+        expectThat(cardBrandEnricher.evaluateCard("${sixteenDigitsDiscoverCardNumber}1")?.isComplete).isFalse()
+        expectThat(cardBrandEnricher.evaluateCard("${sixteenDigitsDiscoverCardNumber}12")?.isComplete).isFalse()
+        expectThat(cardBrandEnricher.evaluateCard("${sixteenDigitsDiscoverCardNumber}123")?.isComplete).isTrue()
     }
 
     @Test