fix: handle revealing january expiration month as a single digit (#99)

Basis-Theory · Feb 1, 2024 · bf61540 · bf61540
1 parent 68fe042
commit bf61540
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/lib/src/main/java/com/basistheory/android/view/CardExpirationDateElement.kt b/lib/src/main/java/com/basistheory/android/view/CardExpirationDateElement.kt
@@ -32,9 +32,12 @@ class CardExpirationDateElement @JvmOverloads constructor(
         monthRef: ElementValueReference,
         yearRef: ElementValueReference
     ) {
-        val month = monthRef.getValue().toIntString()
+        var month = monthRef.getValue().toIntString()
         val year = yearRef.getValue().toIntString()
 
+        // unique edge case not handled by beforeTextChanged since users can enter 10, 11 or 12
+        if (month == "1") month = "01"
+
         setText("${month}${year?.takeLast(2)}")
     }
 

diff --git a/lib/src/test/java/com/basistheory/android/view/CardExpirationDateElementTests.kt b/lib/src/test/java/com/basistheory/android/view/CardExpirationDateElementTests.kt
@@ -154,6 +154,15 @@ class CardExpirationDateElementTests {
         expectThat(cardExpirationDateElement.getText()).isEqualTo("08/30")
     }
 
+    @Test
+    fun `can set value references for january as a single digit`() {
+        val monthRef = ElementValueReference { "1" }
+        val yearRef = ElementValueReference { "2030" }
+        cardExpirationDateElement.setValueRef(monthRef, yearRef)
+
+        expectThat(cardExpirationDateElement.getText()).isEqualTo("01/30")
+    }
+
     @Test
     fun `can set value references for both month and year as doubles`() {
         val monthRef = ElementValueReference { "8.0" }