Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add bashcov report #2102

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

add bashcov report #2102

wants to merge 6 commits into from

Conversation

NoahGorny
Copy link
Member

Fix my prev commit :)

@NoahGorny NoahGorny force-pushed the add-bashcov-report branch 4 times, most recently from fcd4e64 to 0893627 Compare March 3, 2022 19:50
@gaelicWizard
Copy link
Contributor

I think this will be hard to do perfectly until our configuration is outside the tree, and I think we may need to have test/run execute bashcov (with a flag, not always).

Basically, I'm thinking about the git worktree confusing bashcov. I'm thinking about an easy way to keep files in place without stomping on them... let me noodle for a few...

seefood
seefood approved these changes Nov 7, 2024
View reviewed changes
Copy link
Contributor

@seefood seefood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems ok, I won't know till it tests itself :)

@seefood seefood self-assigned this Nov 7, 2024
@seefood seefood added seems abandoned rattle the cage, and close if nobody wants to keep it going waiting-for-response clean up labels Nov 9, 2024
@seefood
Copy link
Contributor

seefood commented Nov 9, 2024

@gaelicWizard Hey John, is this still relevant?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seefood seefood seefood approved these changes

Assignees

@seefood seefood

Labels
clean up seems abandoned rattle the cage, and close if nobody wants to keep it going waiting-for-response
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NoahGorny @gaelicWizard @seefood