lib/helpers: remove log message from _command_exists()
et al
#2065
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Completely remove all logging from
_command_exists()
,_binary_exists()
,_completion_exists()
, and_is_function()
.lib/utilities
.Motivation and Context
These functions are used everywhere and both junk up
bash-it doctor
, but can alsö add unexpected strings to some theme prompt lines!It does not seem like the logging was ever used anywhere prior to my converting the codebase to use it, although it was pointed out that this is often used to short-circuit plugin loading and so the default message could be helpful in
bash-it doctor
. I have a separate PR which adds actual logging to plugins that short-circuit.How Has This Been Tested?
Types of changes
Checklist:
clean_files.txt
and formatted it usinglint_clean_files.sh
.