lib/theme: shfmt, shellcheck, and some cleanup
#2038
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaelicWizard
force-pushed
the
theme/base
branch
from
f0d7c33
to
da71cc6
Compare
gaelicWizard
force-pushed
the
theme/base
branch
6 times, most recently
from
150bdfd
to
43ef5c9
Compare
gaelicWizard
force-pushed
the
theme/base
branch
3 times, most recently
from
56c2d83
to
8616ae4
Compare
gaelicWizard
force-pushed
the
theme/base
branch
3 times, most recently
from
43084a9
to
e32f001
Compare
6 tasks
gaelicWizard
force-pushed
the
theme/base
branch
2 times, most recently
from
afe9142
to
a656f09
Compare
These variables are referenced by themes already linted.
My apologies to future `git blame` hunters ♥
My apologies to future `git blame` hunters ♥
My apologies to future `git blame` hunters ♥
Use the "short" host name by default (`\h`), not the fully qualified domain name (`\H`)...
lib/theme: don't redefine battery_char()
Combine the two definitions for `battery_char()` so the second one doesn't just overwrite the first one. Do one or the other, not both.
Don't evaluate if `battery_percentage()` is available at load time, evaluate it at run time.
Don't run `date` for `$THEME_TIME_FORMAT`, use `\D{fmt}`.
Five years deprecation is plenty warning.
A lot of useless `echo`s in here.
Improve handling of parameters by adding defaults (often blank). Alsö, eliminate newlines from `echo` in many places.
- Don't invoke the source control utility when all we want to know is if we're somewhere inside the repository; use `_bash-it-find-in-ancestor()`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Quote a bunch of things, adopt
shellcheckrecommendations, try to simplify a few parts...Motivation and Context
Simplicity, clarity, and #1696!
How Has This Been Tested?
This is part of my main branch since September and the full test suite passes.
Types of changes
Checklist:
clean_files.txtand formatted it usinglint_clean_files.sh.