Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Plugin/OSX: cleanup #2008

Merged
merged 6 commits into from
Jan 7, 2022
Merged

Plugin/OSX: cleanup #2008

merged 6 commits into from
Jan 7, 2022

Conversation

gaelicWizard
Copy link
Contributor

Description

Run shfmt, shellcheck, remove some dead code, and simplify a little.

Motivation and Context

Just cleaning up.

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the code style of this project.
  • If my change requires a change to the documentation, I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • If I have added a new file, I also added it to clean_files.txt and formatted it using lint_clean_files.sh.
  • I have added tests to cover my changes, and all the new and existing tests pass.

@gaelicWizard gaelicWizard marked this pull request as ready for review December 31, 2021 07:27
@gaelicWizard
tests: quote paths
4abafc5
@gaelicWizard
plugin/osx: shellcheck && shfmt
75aabd5 
plugins/osx: dead code removal

No need for gymnastics to determine if variable had been exported priort to modification. If it was, then it still is. See man bash(1).
@gaelicWizard
plugin/osx: remove dock-switch()
db90279 
...it hasn't worked in *years*
@gaelicWizard
plugin/osx: move $OSTYPE check to top of file
caa0d48
@gaelicWizard
plugins/osx-timemachine: shellcheck && shfmt
03653fc 
Use bash functionality rather than external binaries. Alsö, if $SUDO_ASKPASS is set then pass -A to sudo.
@gaelicWizard
plugin/osx-timemachine: abuse $SUDO_COMMAND
45aeb86 
Use `$SUDO_COMMAND` as a back-channel to `ssh-askpass` to set a reasonable title if it pops up.
NoahGorny
NoahGorny approved these changes Jan 3, 2022
View reviewed changes
Copy link
Member

@NoahGorny NoahGorny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As this is mostly cleanup, I approve

@NoahGorny NoahGorny merged commit 5d68fca into Bash-it:master Jan 7, 2022
@gaelicWizard gaelicWizard deleted the plugin-osx branch January 7, 2022 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NoahGorny NoahGorny NoahGorny approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gaelicWizard @NoahGorny