Create lib finalize hook #2004
Merged
Create lib finalize hook #2004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaelicWizard
force-pushed
the
finalize
branch
from
39e9641
to
37233f3
Compare
gaelicWizard
force-pushed
the
finalize
branch
from
37233f3
to
7a773a1
Compare
6 tasks
gaelicWizard
force-pushed
the
finalize
branch
3 times, most recently
from
6113a43
to
bcadf71
Compare
NoahGorny
reviewed
Jan 3, 2022
gaelicWizard
force-pushed
the
finalize
branch
3 times, most recently
from
cfec924
to
3c057c5
Compare
Create an array `_bash_it_library_finalize_hook` and loop at the end of the main `bash_it.sh` to run each element in the array. The purpose here is to run some command after everything else has been loaded. For example, the appearance lib checks for executables for SCM commands, but `$PATH` may be altered after appearance has loaded and therefore some available commands may never be discovered. Therefore, create `_bash_it_appearance_scm_init()` and add it to the hook. It will re-check at end of `bash_it.sh` just before prompt is first displayed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Create an array
_bash_it_library_finalize_hookand loop at the end of the mainbash_it.shto run each element in the array.Motivation and Context
The purpose here is to run some command after everything else has been loaded. For example,
lib/themechecks for executables for SCM commands, but$PATHmay be altered afterlib/themehas loaded and therefore some available commands may never be discovered. To accommodate this problem, create_bash_it_appearance_scm_init()and add it to the hook. It will re-check at end ofbash_it.shjust before prompt is first displayed.How Has This Been Tested?
This has been part of my main branch for months and all tests pass.
Types of changes
Checklist:
clean_files.txtand formatted it usinglint_clean_files.sh.