tests: path quoting and boilerplate #2002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaelicWizard
force-pushed
the
bats
branch
5 times, most recently
from
45e6985
to
6c7616f
Compare
|
:grumble grumble: the OSX.11 test runner is so slow that it fails the |
6 tasks
gaelicWizard
changed the title
NoahGorny
reviewed
Jan 3, 2022
gaelicWizard
force-pushed
the
bats
branch
2 times, most recently
from
dc67273
to
cace1cb
Compare
gaelicWizard
force-pushed
the
bats
branch
2 times, most recently
from
3272aa5
to
723bebd
Compare
NoahGorny
approved these changes
Jan 7, 2022
...and `cite()`s metadata
For testing non-core files, just `load ../test_helper_libs` after `load ../test_helper` instead of trying to guess which libs must be loaded, in which order, for testing to succeed. `_command_exists` spews log messages, so our test log is littered with `_log_debug not found`. This fixes that too.
Literally copying a line from the source to be tested is perhaps not the best way to test that code. 😉 That said, we do want to verify that the function was actually loaded. TODO: actually test the function.
Test was failing only on Mac OS X for some reason, so refactor a little. It turned out to be due to explicitly setting `$HOME` *after* loading the plugin.
This subshell is...wut
Symlink `/test_lib/bats-core/test/fixtures/parallel/suite/helper.bash` references a not-existing file, but it's in a submodule so I can't just fix it. Exclude it from `rsync` in `setup_test_fixture()`.
7 tasks
NoahGorny
approved these changes
Jan 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
All tests now run when there are spaces in
$BASH_IT, and boilerplate removed from the top of most test files.Motivation and Context
As I'm learning BATS, I'm cleaning up duplicate code and hopefully making the tests faster and more reliable. There's more to do! This is just my first pass.
How Has This Been Tested?
I run the tests manually myself, and alsö through GitHub Actions.
Types of changes
Checklist:
clean_files.txtand formatted it usinglint_clean_files.sh.