Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

plugin/base: improvements #1930

Merged
merged 16 commits into from
Sep 28, 2021
Merged

plugin/base: improvements #1930

merged 16 commits into from
Sep 28, 2021

Commits on Sep 24, 2021

  1. plugins/base: code style improvements 

    Quote variables, use $@ and $array[@] instead of $*, typeset some integers, remove unneccesasary binary invocation, use shell features when possible, remove `eval`, &c.
    @gaelicWizard
    gaelicWizard committed Sep 24, 2021
    Configuration menu
    Copy the full SHA
    63869e0 View commit details
    Browse the repository at this point in the history

  2. plugins/base: conditional function definitions 

    Instead of functions failing when required tools aren't installed, just don't define the function.
Alsö, don't redefine del() if it already exists.
    @gaelicWizard
    gaelicWizard committed Sep 24, 2021
    Configuration menu
    Copy the full SHA
    5cb7522 View commit details
    Browse the repository at this point in the history

  3. plugins/base: rewrite usage() 

    Reimplement disk usage function using Bash syntax and simpler layout, without having to invoke an external binary.
    @gaelicWizard
    gaelicWizard committed Sep 24, 2021
    Configuration menu
    Copy the full SHA
    c3f45b2 View commit details
    Browse the repository at this point in the history

  4. plugins/base: revamp quiet() 

    New implementation that is even quieter.
    @gaelicWizard
    gaelicWizard committed Sep 24, 2021
    Configuration menu
    Copy the full SHA
    41ef92b View commit details
    Browse the repository at this point in the history

  5. plugins/base: myip()

    @gaelicWizard
    gaelicWizard committed Sep 24, 2021
    Configuration menu
    Copy the full SHA
    c975f31 View commit details
    Browse the repository at this point in the history

  6. plugins/base: pickfrom()

    @gaelicWizard
    gaelicWizard committed Sep 24, 2021
    Configuration menu
    Copy the full SHA
    c8ed9a9 View commit details
    Browse the repository at this point in the history

  7. plugins/base: passgen() 

    Fix `passgen()` to not need `tr`, remove one subshell, and eliminate a useless `echo`.
    @gaelicWizard
    gaelicWizard committed Sep 24, 2021
    Configuration menu
    Copy the full SHA
    ea84771 View commit details
    Browse the repository at this point in the history

  8. plugins/base: mkcd()

    @gaelicWizard
    gaelicWizard committed Sep 24, 2021
    Configuration menu
    Copy the full SHA
    9ba76b6 View commit details
    Browse the repository at this point in the history

  9. plugins/base: mkiso()

    @gaelicWizard
    gaelicWizard committed Sep 24, 2021
    Configuration menu
    Copy the full SHA
    49c9c43 View commit details
    Browse the repository at this point in the history

  10. plugins/base: remove banish-cookies() 

    Adobe Flash is gone with the wind. Alsö, this would be something someone would do *once* and shouldn't be a function...
    @gaelicWizard
    gaelicWizard committed Sep 24, 2021
    Configuration menu
    Copy the full SHA
    423729e View commit details
    Browse the repository at this point in the history

  11. plugins/base: lsgrep is SC2010 

    The `lsgrep()` function is *itself* explicitly forbidden by `shellcheck` rule SC2010.

Alsö, s/`$*`/`$@`
    @gaelicWizard
    gaelicWizard committed Sep 24, 2021
    Configuration menu
    Copy the full SHA
    8d3e81a View commit details
    Browse the repository at this point in the history

  12. plugins/base: mkiso() 

    Expressly handle unbound parameters.
    @gaelicWizard
    gaelicWizard committed Sep 24, 2021
    Configuration menu
    Copy the full SHA
    96239a2 View commit details
    Browse the repository at this point in the history

  13. plugins/base: remove command_exists

    @gaelicWizard
    gaelicWizard committed Sep 24, 2021
    Configuration menu
    Copy the full SHA
    280eaf3 View commit details
    Browse the repository at this point in the history

  14. plugin/base: lint SC2154 && SC2144 

    Newly undisabled `shellcheck` rules
    @gaelicWizard
    gaelicWizard committed Sep 24, 2021
    Configuration menu
    Copy the full SHA
    bf5670a View commit details
    Browse the repository at this point in the history

  15. plugin/base: import libs for tests

    @gaelicWizard
    gaelicWizard committed Sep 24, 2021
    Configuration menu
    Copy the full SHA
    45bf719 View commit details
    Browse the repository at this point in the history

  16. plugin/base: shfmt 

    Apply `shfmt` using current project settings. My apologies to future `git blame` hunters. ♥
    @gaelicWizard
    gaelicWizard committed Sep 24, 2021
    Configuration menu
    Copy the full SHA
    e66019d View commit details
    Browse the repository at this point in the history