-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
plugin/base: improvements #1930
Commits on Sep 24, 2021
-
plugins/base: code style improvements
Quote variables, use $@ and $array[@] instead of $*, typeset some integers, remove unneccesasary binary invocation, use shell features when possible, remove `eval`, &c.
Configuration menu - View commit details
-
Copy full SHA for 63869e0 - Browse repository at this point
Copy the full SHA 63869e0View commit details -
plugins/base: conditional function definitions
Instead of functions failing when required tools aren't installed, just don't define the function. Alsö, don't redefine del() if it already exists.
Configuration menu - View commit details
-
Copy full SHA for 5cb7522 - Browse repository at this point
Copy the full SHA 5cb7522View commit details -
Reimplement disk usage function using Bash syntax and simpler layout, without having to invoke an external binary.
Configuration menu - View commit details
-
Copy full SHA for c3f45b2 - Browse repository at this point
Copy the full SHA c3f45b2View commit details -
New implementation that is even quieter.
Configuration menu - View commit details
-
Copy full SHA for 41ef92b - Browse repository at this point
Copy the full SHA 41ef92bView commit details -
Configuration menu - View commit details
-
Copy full SHA for c975f31 - Browse repository at this point
Copy the full SHA c975f31View commit details -
Configuration menu - View commit details
-
Copy full SHA for c8ed9a9 - Browse repository at this point
Copy the full SHA c8ed9a9View commit details -
Fix `passgen()` to not need `tr`, remove one subshell, and eliminate a useless `echo`.
Configuration menu - View commit details
-
Copy full SHA for ea84771 - Browse repository at this point
Copy the full SHA ea84771View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9ba76b6 - Browse repository at this point
Copy the full SHA 9ba76b6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 49c9c43 - Browse repository at this point
Copy the full SHA 49c9c43View commit details -
plugins/base: remove
banish-cookies()
Adobe Flash is gone with the wind. Alsö, this would be something someone would do *once* and shouldn't be a function...
Configuration menu - View commit details
-
Copy full SHA for 423729e - Browse repository at this point
Copy the full SHA 423729eView commit details -
plugins/base:
lsgrep
is SC2010The `lsgrep()` function is *itself* explicitly forbidden by `shellcheck` rule SC2010. Alsö, s/`$*`/`$@`
Configuration menu - View commit details
-
Copy full SHA for 8d3e81a - Browse repository at this point
Copy the full SHA 8d3e81aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 96239a2 - Browse repository at this point
Copy the full SHA 96239a2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 280eaf3 - Browse repository at this point
Copy the full SHA 280eaf3View commit details -
plugin/base: lint SC2154 && SC2144
Newly undisabled `shellcheck` rules
Configuration menu - View commit details
-
Copy full SHA for bf5670a - Browse repository at this point
Copy the full SHA bf5670aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 45bf719 - Browse repository at this point
Copy the full SHA 45bf719View commit details -
Apply `shfmt` using current project settings. My apologies to future `git blame` hunters. ♥
Configuration menu - View commit details
-
Copy full SHA for e66019d - Browse repository at this point
Copy the full SHA e66019dView commit details