Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rbenv version prompt #1789

Merged
merged 1 commit into from
Jan 16, 2021
Merged

Conversation

BarbUk
Copy link
Contributor

@BarbUk BarbUk commented Jan 16, 2021

Description

Fix a typo in rbenv_version_prompt function.

Motivation and Context

When using rbenv_version_prompt to display ruby version
with rbenv installed, there is an error:

bash: 2.7.2: command not found

87% 2021-01-16 09:24:20 ⌚  |2.7.2| ThinkbUk in ~
○ →

The function define a variable containing the ruby version with rbenv version-name
and use that variable like the rbenv binary.

rbenv commands | grep -q gemset is a valid command when using rbenv gemset.

How Has This Been Tested?

No error after modification.
Using rbenv-gemset display the gemset used.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • If my change requires a change to the documentation, I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • If I have added a new file, I also added it to clean_files.txt and formatted it using lint_clean_files.sh.
  • I have added tests to cover my changes, and all the new and existing tests pass.

@BarbUk BarbUk mentioned this pull request Jan 16, 2021
8 tasks
Copy link
Member

@NoahGorny NoahGorny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done @BarbUk !

@NoahGorny NoahGorny merged commit 79df5ff into Bash-it:master Jan 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants