Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NMEA receiving feature (null safety update) #819

Closed
wants to merge 39 commits into from

Conversation

juanmanjarres
Copy link

@juanmanjarres juanmanjarres commented Aug 23, 2021

✨ What kind of change does this PR introduce? (Bug fix, feature, docs update...)

New feature.

⤵️ What is the current behavior?

There is no current option to receive NMEA messages.

🆕 What is the new behavior (if this is a feature change)?

With this PR, you can receive NMEA messages (only on Android N and above, no iOS due to limitations).

💥 Does this PR introduce a breaking change?

No

🐛 Recommendations for testing

📝 Links to relevant issues/docs

Closes #605, closes #561
This PR takes most changes from #605 and updates them to null safety and the latest changes from master.

🤔 Checklist before submitting

  • I made sure all projects build.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I followed the style guide lines (code style guide).
  • I updated the relevant documentation.
  • I rebased onto current master.

Sempakonka and others added 30 commits November 30, 2020 16:05
…to issue#516

� Conflicts:
�	geolocator/CHANGELOG.md
�	geolocator/README.md
�	geolocator/example/lib/main.dart
�	geolocator/pubspec.yaml
�	geolocator_platform_interface/CHANGELOG.md
@codecov
Copy link

codecov bot commented Aug 23, 2021

Codecov Report

Merging #819 (0fe59c1) into master (06649f4) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##            master      #819    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files            1        18    +17     
  Lines           27       277   +250     
==========================================
+ Hits            27       277   +250     
Impacted Files Coverage Δ
...terface/lib/src/geolocator_platform_interface.dart 100.00% <100.00%> (ø)
...src/implementations/method_channel_geolocator.dart 100.00% <100.00%> (ø)
...latform_interface/lib/src/models/nmea_message.dart 100.00% <100.00%> (ø)
...rs/permission_definitions_not_found_exception.dart 100.00% <0.00%> (ø)
...or_platform_interface/lib/src/models/position.dart 100.00% <0.00%> (ø)
...e/lib/src/errors/already_subscribed_exception.dart 100.00% <0.00%> (ø)
...e/lib/src/errors/invalid_permission_exception.dart 100.00% <0.00%> (ø)
...orm_interface/lib/src/models/location_options.dart 100.00% <0.00%> (ø)
...rors/permission_request_in_progress_exception.dart 100.00% <0.00%> (ø)
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 06649f4...0fe59c1. Read the comment docs.

@juanmanjarres
Copy link
Author

juanmanjarres commented Aug 23, 2021

Note: to avoid conflicts, I was using my own GitHub fork for the packages, so the analyzer checks failed. I will update their versions, but note that most checks will fail as I have to update the pubspecs for android, geolocator and geolocator_platform_interface.

@juanmanjarres juanmanjarres marked this pull request as ready for review August 23, 2021 19:01
@rickcasson rickcasson mentioned this pull request Jan 6, 2022
6 tasks
@Wackymax Wackymax mentioned this pull request Apr 11, 2022
6 tasks
@juanmanjarres
Copy link
Author

Closed in favour of #932 as it implements NMEA with the latest changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Getting the number of satellites
3 participants