Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose isPresent platform interface #202

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions geocoding_platform_interface/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 3.2.0

- Adds `isPresent` method to the platform interface.

## 3.1.0

- Adds `placemarkFromAddress` method to the platform interface.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,16 @@ abstract class GeocodingPlatform extends PlatformInterface {
'locationFromAddress() has not been implementated.');
}

/// Returns true if there is a geocoder implementation present that may return results.
/// If true, there is still no guarantee that any individual geocoding attempt will succeed.
///
///
/// This method is only implemented on Android, calling this on iOS always
/// returns [true].
Future<bool> isPresent() {
throw UnimplementedError('isPresent() has not been implementated.');
}

/// Returns a list of [Placemark] instances found for the supplied
/// coordinates.
///
Expand Down
2 changes: 1 addition & 1 deletion geocoding_platform_interface/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ description: A common platform interface for the geocoding plugin.
homepage: https://github.com/baseflow/flutter-geocoding/tree/main/geocoding_platform_interface
# NOTE: We strongly prefer non-breaking changes, even at the expense of a
# less-clean API. See https://flutter.dev/go/platform-interface-breaking-changes
version: 3.1.0
version: 3.2.0

dependencies:
flutter:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,20 @@ void main() {
);
});

test(
// ignore: lines_longer_than_80_chars
'Default implementation of isPresent should throw unimplemented error',
() {
// Arrange
final geocodingPlatform = ExtendsGeocodingPlatform();

// Act & Assert
expect(
() => geocodingPlatform.isPresent(),
throwsUnimplementedError,
);
});

test(
// ignore: lines_longer_than_80_chars
'Default implementation of placemarkFromCoordinates should throw unimplemented error',
Expand Down