Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correct error console props status component publication #822

Merged
merged 2 commits into from
Aug 7, 2023

Conversation

fufeck
Copy link
Contributor

@fufeck fufeck commented Aug 2, 2023

Context

Pour une BAL en conflit j'ai cette erreur dans la console

Capture d’écran 2023-08-02 à 10 03 36

Capture d’écran 2023-08-02 à 10 03 32

Résolution

Ajouter replaced dans les valeur probable de status dans les propTypes du component Publication

@fufeck fufeck requested a review from MaGOs92 August 2, 2023 06:07
@fufeck
Copy link
Contributor Author

fufeck commented Aug 2, 2023

En temps normal j'aurais passé la PR tout seul, mais je ne comprends pas comment cette erreur a pu rester, est ce qu'il y a une autre raison? J'espère que je ne rate de rien d'important??

Copy link
Contributor

@MaGOs92 MaGOs92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

components/sub-header/bal-status/publication.js Outdated Show resolved Hide resolved
@fufeck fufeck force-pushed the fufeck_fix_props-status-component-publication branch from 7047cc8 to e5c3d9e Compare August 7, 2023 05:38
@fufeck fufeck merged commit 6923b33 into master Aug 7, 2023
1 check passed
@fufeck fufeck deleted the fufeck_fix_props-status-component-publication branch August 7, 2023 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants