Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add isDisabled props on DeleteWarningComponent #815

Merged
merged 4 commits into from
Aug 7, 2023

Conversation

fufeck
Copy link
Contributor

@fufeck fufeck commented Jul 25, 2023

Context

#786

@fufeck fufeck linked an issue Jul 25, 2023 that may be closed by this pull request
@fufeck fufeck requested a review from MaGOs92 August 1, 2023 11:46
Copy link
Contributor

@MaGOs92 MaGOs92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MaGOs92
Copy link
Contributor

MaGOs92 commented Aug 1, 2023

Ce n'est pas lié mais j'ai rencontré ce bug en testant la feature : https://www.loom.com/share/9d2403119ee14ae581eeb48159d9c4b5

C'est un souci avec mon setup en local? Ou il faut ajouter une condition à la ligne 30 de items-deleted-list.js?

@fufeck
Copy link
Contributor Author

fufeck commented Aug 2, 2023

Ce n'est pas lié mais j'ai rencontré ce bug en testant la feature : https://www.loom.com/share/9d2403119ee14ae581eeb48159d9c4b5

C'est un souci avec mon setup en local? Ou il faut ajouter une condition à la ligne 30 de items-deleted-list.js?

Merde, bien vu, j'ai fais une boulette lors de la refacto de la corbeille, je mets le fix avec cette PR, je te laisse checker ;)

@fufeck fufeck requested a review from MaGOs92 August 2, 2023 06:00
Copy link
Contributor

@MaGOs92 MaGOs92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes c'est good!

@fufeck fufeck merged commit 99675b0 into master Aug 7, 2023
1 check passed
@fufeck fufeck deleted the fufeck_fix_disable-button-delete branch August 7, 2023 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disable les bouton de l'avertissement lors de la suppression
2 participants