Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ajoute les préférences utilisateur et le mode daltonien #788

Merged
merged 1 commit into from
Aug 8, 2023
Merged

Ajoute les préférences utilisateur et le mode daltonien #788

merged 1 commit into from
Aug 8, 2023

Conversation

MaGOs92
Copy link
Contributor

@MaGOs92 MaGOs92 commented May 26, 2023

Contexte:

Fonctionnalités :

  • Menu préférences utilisateur dans les paramètres. Les préférences utilisateurs sont enregistrées dans le local storage
  • Mode daltionien (En attente de la PR des tiles)

@MaGOs92 MaGOs92 requested a review from fufeck May 26, 2023 14:26
fufeck
fufeck reviewed May 29, 2023
View reviewed changes
Copy link
Contributor

@fufeck fufeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Capture d’écran 2023-05-29 à 17 36 03

Je ne comprends pas pourquoi il y a un espace entre 'la corbeille' et 'télécharger csv' et ensuite une bar en dessous ?

@MaGOs92
Copy link
Contributor Author

MaGOs92 commented Jun 2, 2023

Capture d’écran 2023-05-29 à 17 36 03

Je ne comprends pas pourquoi il y a un espace entre 'la corbeille' et 'télécharger csv' et ensuite une bar en dessous ?

Bien vu, merci!

@MaGOs92 MaGOs92 mentioned this pull request Jun 2, 2023
Merged
@MaGOs92 MaGOs92 marked this pull request as ready for review June 2, 2023 13:01
@fufeck fufeck self-requested a review June 6, 2023 08:01
fufeck
fufeck reviewed Jun 12, 2023
View reviewed changes
Copy link
Contributor

@fufeck fufeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Utiliser les propriété des features pour récupérer les color

@fufeck fufeck linked an issue Jul 10, 2023 that may be closed by this pull request
Mode daltonien #499
Closed
@MaGOs92 MaGOs92 force-pushed the gfay_user-preferences branch 2 times, most recently from f1ed849 to 5fabfef Compare August 3, 2023 12:14
@MaGOs92 MaGOs92 requested a review from fufeck August 3, 2023 12:18
fufeck
fufeck approved these changes Aug 7, 2023
View reviewed changes
Copy link
Contributor

@fufeck fufeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

La PR est bonne, juste un petit truc:

Capture d’écran 2023-08-07 à 11 14 23

Je mettrais préférences utilisateur dans la dernière partie avec gérer les droits car je trouve ca un peu étrange avec la partie des téléchargement

components/settings/user-settings-form.js Outdated Show resolved Hide resolved
contexts/map.js Show resolved Hide resolved
@MaGOs92 MaGOs92 merged commit ad25161 into master Aug 8, 2023
1 check passed
@MaGOs92 MaGOs92 deleted the gfay_user-preferences branch August 8, 2023 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fufeck fufeck fufeck approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Mode daltonien
2 participants
@MaGOs92 @fufeck