Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgraded CI node version to 16, 18 and 20 on github action workflow #117

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Upgraded CI node version to 16, 18 and 20 on github action workflow #117

wants to merge 2 commits into from

Conversation

antoineludeau
Copy link
Member

@antoineludeau antoineludeau commented Apr 5, 2023 •
edited
Loading

Context :

In the goal of making ban-plateforme fully compatible with node version 16, 18 and 20 we need to upgrade the CI to run on the same desired node version.

Enhancements :
This PR aims to :

  • Modify node version in CI to a matrix of 3 versions : 16, 18 and 20,
  • Modify "engine" field in package.json to specify on which node version ban-plateforme can run on.

@antoineludeau antoineludeau force-pushed the antoineludeau/upgrade-node-version-github-action-workflow branch from f8a6959 to debee6c Compare April 5, 2023 15:41
@antoineludeau antoineludeau self-assigned this Apr 5, 2023
@antoineludeau
Copy link
Member Author

En attente de upgrader le serveur sur node 18 avant de merger.

@antoineludeau antoineludeau marked this pull request as draft June 5, 2023 16:24
@antoineludeau antoineludeau force-pushed the antoineludeau/upgrade-node-version-github-action-workflow branch 3 times, most recently from 7b184f8 to 1052a8b Compare October 10, 2023 13:18
@antoineludeau antoineludeau changed the title Upgraded node version from 16.x to 18.x on github action workflow Upgraded CI node version to 16, 18 and 20 on github action workflow Oct 10, 2023
@antoineludeau antoineludeau force-pushed the antoineludeau/upgrade-node-version-github-action-workflow branch from 1052a8b to 46171ca Compare October 10, 2023 13:23
@antoineludeau antoineludeau marked this pull request as ready for review October 10, 2023 13:23
@antoineludeau antoineludeau force-pushed the antoineludeau/upgrade-node-version-github-action-workflow branch from 46171ca to ac81983 Compare October 10, 2023 13:41
@mmortier mmortier linked an issue Dec 4, 2023 that may be closed by this pull request
Compatibilité Node.js 18 BAN BaseAdresseNationale/ban-bal#17
Open
nkokla
nkokla approved these changes Mar 10, 2024
View reviewed changes
.github/workflows/node.js.yml Show resolved Hide resolved
@nkokla nkokla marked this pull request as draft July 4, 2024 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nkokla nkokla nkokla approved these changes

@vinsag vinsag Awaiting requested review from vinsag

Assignees

@antoineludeau antoineludeau

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Compatibilité Node.js 18 BAN
3 participants
@antoineludeau @nkokla @vinsag