Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow users to configure methods for XSSValidator #376

Merged
merged 19 commits into from
Feb 19, 2024

Conversation

GalacticHypernova
Copy link
Contributor

Partially resolves #364

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

This PR introduces a way for users to choose which methods they would like to add for the XSS validator to work.

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes (if not applicable, please state why)
    Will add later.

Copy link

vercel bot commented Feb 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nuxt-security ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 19, 2024 0:55am

@GalacticHypernova GalacticHypernova marked this pull request as draft February 13, 2024 19:34
src/module.ts Outdated Show resolved Hide resolved
@GalacticHypernova GalacticHypernova marked this pull request as draft February 14, 2024 10:43
src/runtime/utils/methods.ts Outdated Show resolved Hide resolved
src/runtime/server/middleware/xssValidator.ts Outdated Show resolved Hide resolved
@GalacticHypernova
Copy link
Contributor Author

I have fixed some of the things you pointed out, I think it may be good now...??
I haven't worked much with modules so I may be missing something that is required to make it work as needed, sorry in advance!

@Baroshem Baroshem marked this pull request as ready for review February 19, 2024 08:47
@Baroshem Baroshem changed the base branch from main to chore/1.2.0 February 19, 2024 12:53
@Baroshem
Copy link
Owner

Thanks @GalacticHypernova !

Looks good to me. I will merge it to 1.2.0 branch and test everything there :)

@Baroshem Baroshem merged commit 6ca3b55 into Baroshem:chore/1.2.0 Feb 19, 2024
3 checks passed
@GalacticHypernova GalacticHypernova deleted the patch-2 branch February 19, 2024 13:16
@GalacticHypernova
Copy link
Contributor Author

Glad to help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

xssValidator and Content-Type: multipart/form-data
2 participants